Skip to content

note since when the things recommended in a deprecation note are supported #16252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

RalfJung
Copy link
Contributor

@RalfJung RalfJung requested review from a team as code owners June 28, 2022 23:17
@ppedrot ppedrot self-assigned this Jun 29, 2022
@ppedrot
Copy link
Member

ppedrot commented Jun 29, 2022

Why not the same for all hint-like locality-free deprecated commands?

@RalfJung
Copy link
Contributor Author

Those are the ones I knew about and cared about enough to do the research required (find out which Coq version the locality was first supported in).

How many more of these warnings are there?

@RalfJung RalfJung closed this Jun 29, 2022
@RalfJung RalfJung reopened this Jun 29, 2022
@ppedrot
Copy link
Member

ppedrot commented Jun 30, 2022

$ git grep "The default value for" -- '*.ml'
tactics/autorewrite.ml:    (fun () -> strbrk "The default value for rewriting hint locality is currently \
tactics/hints.ml:    (fun () -> strbrk "The default value for hint locality is currently \
vernac/classes.ml:  "The default value for Typeclasses Opaque and Typeclasses \
vernac/classes.ml:    (fun () -> strbrk "The default value for instance locality is currently \

@RalfJung
Copy link
Contributor Author

For the other Hint and for Instance, this has been supported since forever, right?

@ppedrot
Copy link
Member

ppedrot commented Jun 30, 2022

At some point we didn't have attributes but only command modifiers, so it depends on how you phrase the claim.

@RalfJung
Copy link
Contributor Author

Looks like #[local] Lemma foo : bar is supported since Coq 8.9. That counts as "forever".

So I don't know other warnings that would currently benefit from this kind of information.

Copy link
Member

@ppedrot ppedrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, fine with me then.

@ppedrot ppedrot added the kind: user messages Error messages, warnings, etc. label Jun 30, 2022
@ppedrot ppedrot modified the milestones: 8.17+rc1, 8.16.0 Jun 30, 2022
@ppedrot
Copy link
Member

ppedrot commented Jun 30, 2022

@coqbot merge now

@coqbot-app coqbot-app bot merged commit 9a6ab0d into rocq-prover:master Jun 30, 2022
ppedrot added a commit to ppedrot/coq that referenced this pull request Jul 4, 2022
@RalfJung RalfJung deleted the supported-since branch November 17, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: user messages Error messages, warnings, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants