-
Notifications
You must be signed in to change notification settings - Fork 80
Use ament_target_dependencies for qt_gui_cpp. #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]>
Buildfarm is expected to fail until we release ament/ament_cmake#259 into a package. CI for this is in ros2/console_bridge_vendor#9 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't approve my own PR, but this looks good to me now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one suggestion.
This must target a |
There's a test failure
|
Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Signed-off-by: Dirk Thomas <[email protected]>
Signed-off-by: Dirk Thomas <[email protected]>
All right, this is looking good! I'm going to do one more CI on all platforms with the changes in ros2/console_bridge_vendor#9 ; assuming that passes, I'll merge and do releases here. |
@ros-pull-request-builder retest this please |
Signed-off-by: Chris Lalancette [email protected]
Needs ros2/console_bridge_vendor#9 to work properly. Still a WIP, as we can't build qt_gui_sip with this in place.