Skip to content

Use ament_target_dependencies for qt_gui_cpp. #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 27, 2020

Conversation

clalancette
Copy link
Contributor

Signed-off-by: Chris Lalancette [email protected]

Needs ros2/console_bridge_vendor#9 to work properly. Still a WIP, as we can't build qt_gui_sip with this in place.

@clalancette
Copy link
Contributor Author

Buildfarm is expected to fail until we release ament/ament_cmake#259 into a package. CI for this is in ros2/console_bridge_vendor#9 (comment)

Copy link
Contributor Author

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't approve my own PR, but this looks good to me now.

Copy link
Contributor

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one suggestion.

@dirk-thomas
Copy link
Contributor

This must target a foxy-devel branch.

@jacobperron
Copy link
Contributor

There's a test failure

def test_import_libqt_gui_cpp_sip():
>       from qt_gui_cpp import libqt_gui_cpp_sip
E       ImportError: /home/jenkins-agent/workspace/ci_linux-aarch64/ws/install/qt_gui_cpp/lib/python3.8/site-packages/qt_gui_cpp/libqt_gui_cpp_sip.so: undefined symbol: g_rcutils_logging_initialized

../../src/ros-visualization/qt_gui_core/qt_gui_cpp/test/test_imports.py:17: ImportError

@dirk-thomas dirk-thomas marked this pull request as draft May 26, 2020 22:32
Copy link
Contributor

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@dirk-thomas
Copy link
Contributor

dirk-thomas commented May 26, 2020

Rerun of Linux-CI to check if the test passes with the latest commit: Build Status.

ImportError: /home/jenkins-agent/workspace/ci_linux/ws/install/qt_gui_cpp/lib/python3.8/site-packages/qt_gui_cpp/libqt_gui_cpp_sip.so: undefined symbol: _ZNK8tinyxml27XMLNode5ValueEv

@dirk-thomas dirk-thomas changed the base branch from crystal-devel to foxy-devel May 26, 2020 23:49
@dirk-thomas dirk-thomas marked this pull request as ready for review May 26, 2020 23:49
@dirk-thomas
Copy link
Contributor

Rerun of Linux-CI to check if the test passes with the latest commits: Build Status

@clalancette
Copy link
Contributor Author

All right, this is looking good! I'm going to do one more CI on all platforms with the changes in ros2/console_bridge_vendor#9 ; assuming that passes, I'll merge and do releases here.

@clalancette
Copy link
Contributor Author

@ros-pull-request-builder retest this please

@clalancette clalancette merged commit 1275811 into foxy-devel May 27, 2020
@clalancette clalancette deleted the ament-target-dependencies branch May 27, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants