We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It would be nice if the string types in rosidl_runtime_rs could be built/extended from iterators, like the regular string type.
rosidl_runtime_rs
For this, we'd need implementations for Extend<char> and FromIterator<char> for both types, at least.
Extend<char>
FromIterator<char>
The text was updated successfully, but these errors were encountered:
Implemented Extend<char>, Extend<&'a char>, FromIterator<char>,…
Extend<&'a char>
661558c
… and `FromIterator<&'a char>` for String and WString ros2-rust#246
An important thing to note, is that this feature gives the string types interior mutability. So these string types would have to lose the Sync impl.
https://github.com/ros2-rust/ros2_rust/blob/main/rosidl_runtime_rs/src/string.rs#L230
Sorry, something went wrong.
I think we wouldn't need to lose the Sync marker, since the Extend trait takes &mut self and not &self.
Sync
Extend
&mut self
&self
Ahh, gotcha. Yeah even rust's String is Sync https://doc.rust-lang.org/std/string/struct.String.html#impl-Sync-for-String
String
Updated in the PR
I believe this issue should be closed now that #293 has been merged
No branches or pull requests
It would be nice if the string types in
rosidl_runtime_rs
could be built/extended from iterators, like the regular string type.For this, we'd need implementations for
Extend<char>
andFromIterator<char>
for both types, at least.The text was updated successfully, but these errors were encountered: