Skip to content

Disable clippy warnings for u128 types #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2023
Merged

Disable clippy warnings for u128 types #322

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3aef926
Disable clippy warnings for u128 types
esteve Jul 13, 2023
80bb0ac
Added note about the rationale for improper_ctypes for clippy
esteve Jul 14, 2023
042d7e1
Fix formatting
esteve Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions rclrs/src/rcl_bindings.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
#![allow(non_upper_case_globals)]
#![allow(non_camel_case_types)]
#![allow(non_snake_case)]
// Added to avoid clippy complaining about u128 types not being FFI safe
// Caused by https://github.com/ros2/ros2/issues/1374 in iron and newer
// See https://github.com/ros2-rust/ros2_rust/issues/320
#![allow(improper_ctypes)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be a good idea to separate this not allow from the rest of the blocks and add a comment referencing that its coming from ROS 2's new runtime reflection feature in Iron and Rolling. I can see this list getting quite long and goofy over time

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 80bb0ac

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to fix the formatting because rustfmt was complaining.

#![allow(clippy::all)]
#![allow(missing_docs)]

Expand Down