Skip to content

add serde big array support (fixed #327) #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 22, 2023

Conversation

fawdlstty
Copy link
Contributor

@fawdlstty fawdlstty commented Aug 18, 2023

fixed #327

@esteve esteve self-requested a review August 21, 2023 15:30
@esteve
Copy link
Collaborator

esteve commented Aug 21, 2023

@fawdlstty thanks for the fix! I only have one that should be addressed.

@fawdlstty fawdlstty requested a review from esteve August 22, 2023 05:45
Copy link
Collaborator

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fawdlstty LGTM, thanks for addressing my feedback.

@esteve esteve merged commit 6c87533 into ros2-rust:main Aug 22, 2023
@fawdlstty fawdlstty deleted the fix-deseriilize-compile-failed branch August 22, 2023 14:04
luca-della-vedova pushed a commit to luca-della-vedova/ros2_rust that referenced this pull request Sep 20, 2023
esteve added a commit that referenced this pull request Oct 27, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* WIP Add minimal TimeSource implementation

Signed-off-by: Luca Della Vedova <[email protected]>

* Minor cleanup and code reorganization

Signed-off-by: Luca Della Vedova <[email protected]>

* Minor cleanups, add debug code

Signed-off-by: Luca Della Vedova <[email protected]>

* Minor cleanup

Signed-off-by: Luca Della Vedova <[email protected]>

* Change safety note to reflect get_now safety

Signed-off-by: Luca Della Vedova <[email protected]>

* Fix comment spelling

Co-authored-by: jhdcs <[email protected]>

* Cleanup and add some docs / tests

Signed-off-by: Luca Della Vedova <[email protected]>

* Avoid duplicated clocks in TimeSource

Signed-off-by: Luca Della Vedova <[email protected]>

* Change _rcl_clock to just Mutex

Signed-off-by: Luca Della Vedova <[email protected]>

* Remove Mutex from node clock

Signed-off-by: Luca Della Vedova <[email protected]>

* Change Mutex<bool> to AtomicBool

Signed-off-by: Luca Della Vedova <[email protected]>

* Avoid cloning message

Signed-off-by: Luca Della Vedova <[email protected]>

* Minor cleanup, add dependency

Signed-off-by: Luca Della Vedova <[email protected]>

* Remove hardcoded use_sim_time

Signed-off-by: Luca Della Vedova <[email protected]>

* Cleanup remaining warnings / clippy

Signed-off-by: Luca Della Vedova <[email protected]>

* Fix tests

Signed-off-by: Luca Della Vedova <[email protected]>

* Refactor API to use ClockSource

Signed-off-by: Luca Della Vedova <[email protected]>

* Fix Drop implementation, finish builder and add comments

Signed-off-by: Luca Della Vedova <[email protected]>

* Minor cleanups

Signed-off-by: Luca Della Vedova <[email protected]>

* Fix graph_tests

Signed-off-by: Luca Della Vedova <[email protected]>

* Remove Arc from time source

Signed-off-by: Luca Della Vedova <[email protected]>

* Remove Sync trait, format

Signed-off-by: Luca Della Vedova <[email protected]>

* Add comparison function for times, use reference to clock

Signed-off-by: Luca Della Vedova <[email protected]>

* Implement Add<Duration> and Sub<Duration> for Time

Signed-off-by: Luca Della Vedova <[email protected]>

* Make node pointer Weak to avoid memory leaks

Signed-off-by: Luca Della Vedova <[email protected]>

* Cleanups

Signed-off-by: Luca Della Vedova <[email protected]>

* WIP change clock type when use_sim_time parameter is changed

Signed-off-by: Luca Della Vedova <[email protected]>

* Remove need for mutex in node TimeSource

Signed-off-by: Luca Della Vedova <[email protected]>

* Change get_clock() to return cloned Clock object

Signed-off-by: Luca Della Vedova <[email protected]>

* Minor cleanup

Signed-off-by: Luca Della Vedova <[email protected]>

* Refactor spin and spin_once to mimic rclcpp's Executor API (#324)

* Added rclcpp/rclpy-like executor

* Fix comments

* add serde big array support (fixed #327) (#328)

* add serde big array support

* Fixed an issue where cpu usage remained at 100% (#330)

* Make get_parameter pub(crate)

Signed-off-by: Luca Della Vedova <[email protected]>

* Address review feedback

Signed-off-by: Luca Della Vedova <[email protected]>

* Make time_source pub(crate), remove unused APIs

Signed-off-by: Luca Della Vedova <[email protected]>

* WIP parameter interface implementation

Signed-off-by: Luca Della Vedova <[email protected]>

* Migrate to proposed API

Signed-off-by: Luca Della Vedova <[email protected]>

* Add API for mandatory and optional parameters

Signed-off-by: Luca Della Vedova <[email protected]>

* First round of unit tests for parameter API

Signed-off-by: Luca Della Vedova <[email protected]>

* Make complex parameter types Arc

Signed-off-by: Luca Della Vedova <[email protected]>

* First attempt at undeclared parameter API

Signed-off-by: Luca Della Vedova <[email protected]>

* First attempt at automatic parameter undeclaring

Signed-off-by: Luca Della Vedova <[email protected]>

* Change undeclared_parameter API to be more explicit

Signed-off-by: Luca Della Vedova <[email protected]>

* Minor cleanup, use atomic for undeclared params

Signed-off-by: Luca Della Vedova <[email protected]>

* Add docs

Signed-off-by: Luca Della Vedova <[email protected]>

* Add more tests

Signed-off-by: Luca Della Vedova <[email protected]>

* Update setter for optional parameters

Signed-off-by: Luca Della Vedova <[email protected]>

* Add unset api for optional parameters

Signed-off-by: Luca Della Vedova <[email protected]>

* Cleanup and add helper functions for arrays

Signed-off-by: Luca Della Vedova <[email protected]>

* Add type alias

Signed-off-by: Luca Della Vedova <[email protected]>

* Reduce number of generics, add more tests

Signed-off-by: Luca Della Vedova <[email protected]>

* Refactor to include parameter ranges and read_only

Signed-off-by: Luca Della Vedova <[email protected]>

* Refactor ranges

Signed-off-by: Luca Della Vedova <[email protected]>

* Revert API change for range builder

Signed-off-by: Luca Della Vedova <[email protected]>

* Add ParameterValueError variant

Signed-off-by: Luca Della Vedova <[email protected]>

* First implementation of tentative API

Signed-off-by: Luca Della Vedova <[email protected]>

* Rework API for unified declaration syntax

Signed-off-by: Luca Della Vedova <[email protected]>

* Add missing APIs

Signed-off-by: Luca Della Vedova <[email protected]>

* Add error variant for default out of range

Signed-off-by: Luca Della Vedova <[email protected]>

* Refactor and remove duplicated code

Signed-off-by: Luca Della Vedova <[email protected]>

* Revert change to parameter service file

Signed-off-by: Luca Della Vedova <[email protected]>

* Remove time related changes

Signed-off-by: Luca Della Vedova <[email protected]>

* Clarify doc for unset API

Signed-off-by: Luca Della Vedova <[email protected]>

* Fix comments / TODOs

Signed-off-by: Luca Della Vedova <[email protected]>

* Remove Arc<RwLock> wrapper from undeclared params

Signed-off-by: Luca Della Vedova <[email protected]>

* Add short description of deviations from other client libraries

Signed-off-by: Luca Della Vedova <[email protected]>

* Address minor feedback

Signed-off-by: Luca Della Vedova <[email protected]>

* Remove duplicated range

Signed-off-by: Luca Della Vedova <[email protected]>

* Change maybe_from to try_from

Signed-off-by: Luca Della Vedova <[email protected]>

* WIP converting to default value builder argument

Signed-off-by: Luca Della Vedova <[email protected]>

* Add type for test

Signed-off-by: Luca Della Vedova <[email protected]>

* Infer arrays and allow custom discriminators

Signed-off-by: Michael X. Grey <[email protected]>

* Fix CI

Signed-off-by: Luca Della Vedova <[email protected]>

* Fix some documentation

Signed-off-by: Michael X. Grey <[email protected]>

* Fix doc link

Signed-off-by: Luca Della Vedova <[email protected]>

* Minor cleanups and optimizations

Signed-off-by: Luca Della Vedova <[email protected]>

* Fix outdated docstrings

Signed-off-by: Luca Della Vedova <[email protected]>

* Add links in documentation / address clippy warnings

Signed-off-by: Luca Della Vedova <[email protected]>

---------

Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Co-authored-by: jhdcs <[email protected]>
Co-authored-by: Esteve Fernandez <[email protected]>
Co-authored-by: Fawdlstty <[email protected]>
Co-authored-by: Michael X. Grey <[email protected]>
@esteve esteve mentioned this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compile failed when deserilize msg struct
2 participants