Use the v3 API for creating gists #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 26, 2013 11:34
Previously would only show errors with HTTP 2xx responses
v1 & v2 have been dead for quite a while
Can be created at https://github.com/settings/applications, then set with "git config --global github.token bef91b559df0014f71c212fc44171b5bc6de12e9a"
|
Thanks! |
|
Changes seem good. I'll be adding some other fun settings soon, so I'll take a look at the UI for this if it hasn't been done by then. |
|
I had some issues with running this just sat on the upload spinner indefinitely, but it seems to have cleared up now; so perhaps that was just some caching/webservice weirdness. Merging as-is because it seems to be working just fine now. Thanks for the fix! |
rowanj
added a commit
that referenced
this pull request
Jul 3, 2013
rowanj
added a commit
that referenced
this pull request
Jul 3, 2013
Also, put pull request #203 under the correct version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
As far as I can tell, the "Gist it" button has been dead for a while. This series of commits fixes it up to use the latest version of the github API.
The one part I'm not too sure about is using github.token. If you haven't set this in your config, it'll just post anonymous gists. If you obtain a personal token from https://github.com/settings/applications and set github.token to it, it'll create gists tied to your account. However, github.token dates back from ancient times, and I'm not sure if I should be reusing it in this way (or if old github.token's are still valid for OAuth authentication). Perhaps it should be a new UI field in GitX's preferences rather than a git config value...