Skip to content

Improve TruffleRuby compatibility #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 18, 2022
Merged

Improve TruffleRuby compatibility #943

merged 5 commits into from
Mar 18, 2022

Conversation

chrisseaton
Copy link
Member

No description provided.

eregon
eregon reviewed Mar 14, 2022
View reviewed changes
@eregon
Copy link
Collaborator

eregon commented Mar 14, 2022

From the look of some failures on #943 some seem due to kwargs handling, so I'll get that work merged in truffleruby and then look at this again.

@eregon eregon self-assigned this Mar 14, 2022
@chrisseaton chrisseaton force-pushed the truffleruby-compatibility branch 2 times, most recently from d4d3869 to 7653d75 Compare March 15, 2022 13:42
chrisseaton
chrisseaton commented Mar 16, 2022
View reviewed changes
@chrisseaton chrisseaton force-pushed the truffleruby-compatibility branch from 7653d75 to 437f6d2 Compare March 16, 2022 14:45
@eregon
Copy link
Collaborator

eregon commented Mar 16, 2022

The kwargs-related failures were due to incorrect delegation in concurrent-ruby (incorrect on Ruby 2.7 and on TruffleRuby 22.0). They are fixed now.

@eregon eregon force-pushed the truffleruby-compatibility branch 2 times, most recently from fcc4e0c to c5c37a8 Compare March 16, 2022 16:18
@eregon eregon force-pushed the truffleruby-compatibility branch 2 times, most recently from 84b1e05 to 7da7e2d Compare March 17, 2022 12:35
@eregon eregon marked this pull request as ready for review March 17, 2022 12:35
eregon
eregon approved these changes Mar 17, 2022
View reviewed changes
Copy link
Collaborator

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisseaton This is ready now, and the CI passed

@chrisseaton
Copy link
Member Author

GitHub is back up, still some CI failures. I want to release tomorrow if I can. What do you think?

@chrisseaton chrisseaton mentioned this pull request Mar 17, 2022
Merged
@eregon eregon force-pushed the truffleruby-compatibility branch from 0067001 to e4b4ff2 Compare March 18, 2022 00:27
@eregon
Copy link
Collaborator

eregon commented Mar 18, 2022

I pushed what I had locally now that GitHub works.

In any case, feel free to release, I think concurrent-ruby works fine on truffleruby (and not worse than before).
Regarding #931 I'll take a look to improve the test, but I don't think it's a release blocker either.

@eregon
Copy link
Collaborator

eregon commented Mar 18, 2022

All green, I'm merging.

If there are new flaky test runs we can skip tests like in e4b4ff2, or if it's not specific tests then temporarily remove it from the push/PR CI (it's already run daily anyway) + open issue to investigate them.

@eregon eregon merged commit 8ffa7bb into master Mar 18, 2022
@eregon eregon deleted the truffleruby-compatibility branch March 18, 2022 00:51
@headius headius mentioned this pull request Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees

@eregon eregon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisseaton @eregon