-
Notifications
You must be signed in to change notification settings - Fork 252
Encode true as xFF #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encode true as xFF #142
Conversation
According to the spec: http://tools.ietf.org/html/rfc4511#section-5.1
We allow this since the library requires Ruby 1.9+
Ruby 1.8.7 has been retired for well over a year. Moving ahead, we should assume 1.9+ only. Once this is merged and released, it will mark the first release that does not support ~1.8.7. We should make that explicit by setting appropriate Gemspec flags. |
ruby 1.9.3+ requirement enforced in #145 |
I think this is sufficiently covered by the search integration test since the default size limit is |
@jch size isn't a boolean, though, since this PR only applies to the BER encoding of the |
Luckily for us, I think all we have to do is use a non-existing sort control and set the criticality to |
Oops, my brain just autocompleted boolean to 0 and 1, but ya what you said makes sense. |
@jch ready for your review. |
🚢 |
Encode true as xFF
According to the spec (http://tools.ietf.org/html/rfc4511#section-5.1), we're currently encoding
true
incorrectly as\x01\x01\x01
instead of\x01\x01\xFF
.Fixes #31.
Wouldn't mind finding a good integration test for this, but nothing obvious or direct comes to mind.
cc @jch @schaary