Skip to content

Ensuring StringIO's encoding in CSV.generate #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Ensuring StringIO's encoding in CSV.generate #111

merged 1 commit into from
Nov 25, 2019

Conversation

hanachin
Copy link
Contributor

2.6

% ruby -EUTF-8:UTF-8 -ve 'require "csv"; p CSV.generate(String.new(encoding: Encoding::Big5), encoding: Encoding::Big5) {|csv| csv << ["漢字"] }.encoding'
ruby 2.6.5p114 (2019-10-01 revision 67812) [x86_64-linux]
#<Encoding:Big5>

master

% ruby -EUTF-8:UTF-8 -ve 'require "csv"; p CSV.generate(String.new(encoding: Encoding::Big5), encoding: Encoding::Big5) {|csv| csv << ["漢字"] }.encoding'
ruby 2.7.0dev (2019-11-23T07:06:30Z master b563439274) [x86_64-linux]
#<Encoding:UTF-8>

This branch

% bundle exec ruby -EUTF-8:UTF-8 -ve 'require "csv"; p CSV.generate(String.new(encoding: Encoding::Big5), encoding: Encoding::Big5) {|csv| csv << ["漢字"] }.encoding'
ruby 2.7.0dev (2019-11-23T07:06:30Z master b563439274) [x86_64-linux]
#<Encoding:Big5>

@hanachin hanachin marked this pull request as ready for review November 24, 2019 15:24
@kou kou merged commit dbf55ef into ruby:master Nov 25, 2019
@kou
Copy link
Member

kou commented Nov 25, 2019

Thanks!

@hanachin hanachin deleted the csv_generate_encoding branch November 25, 2019 01:10
@cypx cypx mentioned this pull request May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants