CI: Add the bundle exec
#192
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the `bundle exec` if we can add it to the commands. I didn't add the `bundle exec` for the `rake install`, `rake test` commands, because I saw the following failures when adding the `bundle exec` to these commands. * .github/workflows/ci.yml - step `bundle exec rake install`. https://github.com/junaruga/ruby-fiddle/actions/runs/17922685051/job/50961337638 * .github/workflows/libffi.yml - step "Run test" - `bundle exec rake test` failed in the `test_no_memory_leak`. https://github.com/junaruga/ruby-fiddle/actions/runs/17922685028/job/50961337379
Member
Author
|
I see the following failure in my fork repository. Is this failure related to this PR? |
Member
Author
|
This PR comes from the #191 reviews. However, I feel using the |
Member
|
OK. Let's not use |
Member
Author
|
All right. I would close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
bundle execif we can add it to the commands. I didn't add thebundle execfor therake install,rake testcommands, because I saw the following failures when adding thebundle execto these commands.bundle exec rake install. https://github.com/junaruga/ruby-fiddle/actions/runs/17922685051/job/50961337638bundle exec rake testfailed in thetest_no_memory_leak. https://github.com/junaruga/ruby-fiddle/actions/runs/17922685028/job/50961337379