Skip to content

Refactor VM exec loop #8182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
matzbot merged 3 commits into from
Aug 8, 2023
Merged

Refactor VM exec loop #8182

matzbot merged 3 commits into from
Aug 8, 2023

Conversation

@nobu
Copy link
Member

@nobu nobu commented Aug 6, 2023

No description provided.

@nobu nobu requested review from k0kubun and kateinoigakukun August 6, 2023 15:46
kateinoigakukun
kateinoigakukun approved these changes Aug 7, 2023
View reviewed changes
k0kubun
k0kubun reviewed Aug 7, 2023
View reviewed changes
k0kubun
k0kubun approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@k0kubun k0kubun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nobu
Copy link
Member Author

nobu commented Aug 7, 2023

@kateinoigakukun If try_f and catch_f could return a value and rb_wasm_try_catch_loop_run would return it, result in struct rb_vm_exec_context can be removed.

@matzbot matzbot merged commit 694d99d into ruby:master Aug 8, 2023
@nobu nobu deleted the vm_loop branch August 8, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@k0kubun k0kubun k0kubun approved these changes

@kateinoigakukun kateinoigakukun kateinoigakukun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nobu @k0kubun @kateinoigakukun @matzbot