Fix the config suggestion in the warning for $ bundle
#9164
+8
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `install_or_cli_help` does not exist for older Bundler like Bundler 2 and so results in a confusing error on Bundler 2: ``` $ bundle Could not find command "". ``` * See https://github.com/ruby/rubygems/pull/9136/files#r2592366837 * Merge the behavior of `install_or_cli_help` in `install`.
eregon
force-pushed
the
fix-broken-config-recommendation-in-default-command-warning
branch
from
41fadbe to
8395b28
Compare
hsbt
requested changes
Dec 8, 2025
|
|
||
| ### Bug fixes: | ||
|
|
||
| - Fix the suggestion in the warning for the default `bundle` command [#9164](https://github.com/ruby/rubygems/pull/9164) |
Member
There was a problem hiding this comment.
Please remove this. It will handle release script automatically.
| end | ||
|
|
||
| desc "install_or_cli_help", "Tries to run bundle install but prints a summary of bundler commands if there is no Gemfile", hide: true | ||
| def install_or_cli_help |
Member
There was a problem hiding this comment.
We should keep this task and warn to suggest update default_cli_command to install.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install_or_cli_helpdoes not exist for older Bundler like Bundler 2 and so results in a confusing error on Bundler 2:$ bundle Could not find command "".install_or_cli_helpininstall.What was the end-user or developer problem that led to this PR?
From https://github.com/ruby/rubygems/pull/9136/files#r2592366837
The suggestion of
bundle config set default_cli_command install_or_cli_help --globalis bad because it breaks on Bundler 2:So the suggestion should be
installand notinstall_or_cli_help.And the
installcommand can have that help behavior on missing gemfile, it's fine and simple.What is your fix for the problem, implemented in this PR?
Make the behavior of
install_or_cli_helppart ofinstalland suggest to configinstallas the default command in that warning, becauseinstallalways existed, whileinstall_or_cli_helpis only in Bundler 4.Make sure the following tasks are checked