bug: Adjust encoder frame rate based on max_fps(/src/main.rs) #142
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set encoder frame rate based on max_fps argument if provided.
Author
|
currnet recording quality current.mp4modified recording quality output.mp4Tested on: fedora43 linux + sway + 540hz fixed display refresh rate |
russelltg
requested changes
Dec 21, 2025
Owner
russelltg
left a comment
russelltg
left a comment
There was a problem hiding this comment.
I'm somewhat surprised that this affects quality at all, but a good find regardless.
src/main.rs
Outdated
| enc.set_frame_rate(Some(framerate)); | ||
|
|
||
| let encoder_framerate = if let Some(max_fps) = args.max_fps { | ||
| Rational(max_fps as i32, 1) |
Owner
There was a problem hiding this comment.
This will handle fractional framerates poorly, and also it should prob be min(max_fps, display_framerate) yeah?
Better handle fractional framerate. Select min(max_fps, framerate) as encoder framerate.
russelltg
requested changes
Dec 29, 2025
Owner
russelltg
left a comment
russelltg
left a comment
There was a problem hiding this comment.
sorry i wasn't clearer about exactly how i wanted this done
russelltg
requested changes
Dec 29, 2025
pilot-whale
commented
Dec 29, 2025
Author
pilot-whale
left a comment
pilot-whale
left a comment
There was a problem hiding this comment.
Sorry,I did not get you clearly earlier.
Co-authored-by: Russell Greene <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set encoder frame rate based on max_fps argument if provided.
Problem: The video encoder always uses the display refresh rate as its own framerate, while the
--max_fpsargument only reduces the number of frames sent to the encoder. This mismatch results in blurry frames, particularly when the--max_fpsis significantly lower than the display refresh rate.Tested on: fedora43 linux + sway
Let me know if anything needs to be adjusted.