This repository was archived by the owner on Nov 30, 2022. It is now read-only.
Update error implementations for the new MSRV #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
approved these changes
Jun 1, 2022
|
I added an additional patch that adds |
apoelstra
approved these changes
Jun 2, 2022
The module `impls` holds implementations of traits found in `std` and `core2` but not in `core`; `io::Read` should be implemented in the `impls` module. Move `io::Read` implementation to the `impls` module.
Now that we have bumped the MSRV we should implement `error::Error` as it is defined for Rust 1.41.1 that means implementing `source` instead of `cause` and `description`. We only have two error types, implement `source` for both of them.
As we are doing in `rust-bitcoin`; to enhance forward compatability, and ease the upgrade path for downstream projects, add `non_exhaustive` to all error types.
|
Rebased to fix merge conflicts, no other changes. |
apoelstra
approved these changes
Jun 10, 2022
|
Is this one going in? If so can we merge and then freeze |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
sourcefor all error types (there are only two). Done because we have bumped the MSRV. First two patches are preparatory cleanup.