Skip to content

secp-sys: change symbol names to 0_6_1 from 0_5_0#490

Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom
apoelstra:2022-10--sys-061
Oct 12, 2022
Merged

secp-sys: change symbol names to 0_6_1 from 0_5_0#490
apoelstra merged 1 commit intorust-bitcoin:masterfrom
apoelstra:2022-10--sys-061

Conversation

@apoelstra
Copy link
Copy Markdown
Member

Needed to build secp-sys 0.5 and secp-sys 0.6 in the same tree. Fixes #489.

This PR can be reproduced by running

./vendor-libsecp.sh depend/ 0_6_1 a1102b12196ea27f44d6201de4d25926a2ae9640

in the secp256k1-sys directory.

Needed to build secp-sys 0.5 and secp-sys 0.6 in the same tree. Fixes rust-bitcoin#489.

This PR can be reproduced by running

    ./vendor-libsecp.sh depend/ 0_6_1 a1102b1

in the secp256k1-sys directory.
Copy link
Copy Markdown
Member

@elichai elichai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 91f1096
Reproduced the same diff locally

@apoelstra apoelstra merged commit 5e1e012 into rust-bitcoin:master Oct 12, 2022
@apoelstra apoelstra deleted the 2022-10--sys-061 branch October 12, 2022 15:32
@apoelstra
Copy link
Copy Markdown
Member Author

Published. Checked that rust-bitcoin still builds and I didn't somehow break it.

@apoelstra
Copy link
Copy Markdown
Member Author

Not going to bother yanking 0.6.0. It's not actually harmful for people to use it.

chain-forgexcr45 added a commit to chain-forgexcr45/rust-secp256k1 that referenced this pull request Sep 28, 2025
…to `0_6_1` from `0_5_0`

91f10965b3947b0b1b00bc6b63664f9001090a40 secp-sys: change symbol names to `0_6_1` from `0_5_0` (Andrew Poelstra)

Pull request description:

  Needed to build secp-sys 0.5 and secp-sys 0.6 in the same tree. Fixes #489.

  This PR can be reproduced by running

      ./vendor-libsecp.sh depend/ 0_6_1 a1102b12196ea27f44d6201de4d25926a2ae9640

  in the secp256k1-sys directory.

ACKs for top commit:
  elichai:
    tACK 91f10965b3947b0b1b00bc6b63664f9001090a40

Tree-SHA512: 0ce5149c9c4b7b44592dec84f1a6348f62437e679c15300efe0e2cc55ced5746e6061c596c83e18428841efb7df07c5cb443a0fd81800dc2a05da9a4f7a07c1a
william2332-limf added a commit to william2332-limf/rust-secp256k1 that referenced this pull request Oct 2, 2025
…to `0_6_1` from `0_5_0`

91f10965b3947b0b1b00bc6b63664f9001090a40 secp-sys: change symbol names to `0_6_1` from `0_5_0` (Andrew Poelstra)

Pull request description:

  Needed to build secp-sys 0.5 and secp-sys 0.6 in the same tree. Fixes #489.

  This PR can be reproduced by running

      ./vendor-libsecp.sh depend/ 0_6_1 a1102b12196ea27f44d6201de4d25926a2ae9640

  in the secp256k1-sys directory.

ACKs for top commit:
  elichai:
    tACK 91f10965b3947b0b1b00bc6b63664f9001090a40

Tree-SHA512: 0ce5149c9c4b7b44592dec84f1a6348f62437e679c15300efe0e2cc55ced5746e6061c596c83e18428841efb7df07c5cb443a0fd81800dc2a05da9a4f7a07c1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot build secp-sys 0.5 and 0.6 in same tree

2 participants