Skip to content

Fix path for rust-lang favicon #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2019
Merged

Fix path for rust-lang favicon #120

merged 1 commit into from
Jan 4, 2019

Conversation

nlopes
Copy link
Contributor

@nlopes nlopes commented Dec 18, 2018

This commit sorts out a couple of issues:

  • fix broken path to rust-lang favicon
  • use https for rust-lang addresses to stop content mixing when visiting over https

Both issues can be seen in the screenshot of my chrome console below:
screenshot 2018-12-18 at 13 40 43

KodrAus
KodrAus approved these changes Jan 4, 2019
View reviewed changes
Copy link
Collaborator

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nlopes!

@KodrAus KodrAus merged commit acc1b2c into rust-cli:master Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KodrAus KodrAus KodrAus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlopes @KodrAus