Skip to content

Conversation

@adamgreig
Copy link
Member

No description provided.

@adamgreig adamgreig requested a review from a team as a code owner February 17, 2019 23:16
@rust-highfive
Copy link

r? @korken89

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Feb 17, 2019
@Disasm Disasm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2019
@Disasm
Copy link
Member

Disasm commented Mar 3, 2019

Ping from triage: @korken89, could you review this?

Copy link
Collaborator

@korken89 korken89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@korken89
Copy link
Collaborator

korken89 commented May 1, 2019

bors r+

bors bot added a commit that referenced this pull request May 1, 2019
165: Clarify list of available targets for installation r=korken89 a=adamgreig



Co-authored-by: Adam Greig <[email protected]>
@bors
Copy link
Contributor

bors bot commented May 1, 2019

Build succeeded

@bors bors bot merged commit b1b0389 into master May 1, 2019
@bors bors bot deleted the adamgreig-install-targets branch May 1, 2019 15:37
Manishearth added a commit to Manishearth/rust that referenced this pull request May 17, 2019
Update books

## nomicon

1 commits in fb29b147be4d9a1f8e24aba753a7e1de537abf61..c656171b749b7307f21371dd0d3278efee5573b8
2019-04-22 19:10:29 -0400 to 2019-04-25 15:31:26 -0400
- Lifetimes: Updates to incorporate NLL (rust-lang/nomicon#101)

## reference

5 commits in 2a2de9c..862b669
2019-04-22 10:25:52 -0700 to 2019-05-04 23:41:35 -0700
- Typo (rust-lang/reference#606)
- Added missing ? to Generics from InherentImpl and TraitImpl (rust-lang/reference#604)
- Add missing ( to ExternalFunctionItem (rust-lang/reference#603)
- Remove unneeded | from AssignmentExpression (rust-lang/reference#601)
- Remove unneeded ( from TypePathSegment (rust-lang/reference#602)

## book

6 commits in db919bc6bb9071566e9c4f05053672133eaac33e..29fe982990e43b9367be0ff47abc82fb2123fd03
2019-04-15 20:11:03 -0400 to 2019-05-15 17:48:40 -0400
- Ignore a non-compiling test listing and add code to fix a test listing
- Remove nostarch snapshots I've checked in layout
- Reword error messages to maybe not need to wrap lines in print
- This example doesn't compile but wasn't marked as such
- Update install instructions for VS 2019 (rust-lang/book#1923)
- Switch IRC to Discord

## rust-by-example

9 commits in 1ff0f8e018838a710ebc0cc1a7bf74ebe73ad9f1..811c697b232c611ed754d279ed20643a0c4096f6
2019-04-15 08:15:32 -0300 to 2019-04-28 18:56:42 -0300
- Fix typo in dsl.md (rust-lang/rust-by-example#1187)
- File read lines (rust-lang/rust-by-example#1186)
- For rust-lang/rust-by-example#1184 closes rust-lang/rust-by-example#1184 (rust-lang/rust-by-example#1185)
- Link to Reference for macro_rules designators (rust-lang/rust-by-example#1182)
- Improve section Meta/Docs (rust-lang/rust-by-example#1183)
- Small improvements to various files (rust-lang/rust-by-example#1173)
- 19.2 Vectors Error in Code Example (rust-lang/rust-by-example#1178)
- For rust-lang/rust-by-example#1175 (rust-lang/rust-by-example#1176)
- For rust-lang/rust-by-example#1179 (rust-lang/rust-by-example#1180)

## rustc-guide

12 commits in 99e1b1d..3cb727b
2019-04-20 09:57:54 -0500 to 2019-05-07 09:53:32 -0500
- Fix typo, 'which' repeated twice
- [canonicalization] fix result canonicalization example (rust-lang/rustc-dev-guide#304)
- Rename to RUSTC_LOG
- Added mention of universal ctags
- Fix link in walkthrough
- Remove IRC from discussion chats
- Bring the updating LLVM guide up to date
- use nightly rust for ci
- Fixed broken chalk links
- Add documentation for two-phase borrows
- Explain new powers of the `treat-err-as-bug` flag
- Update lowering-module test case

## edition-guide

3 commits in c413d42a207bd082f801ec0137c31b71e4bfed4c..581c6cccfaf995394ea9dcac362dc8e731c18558
2019-04-22 01:14:56 +0200 to 2019-05-06 12:47:44 -0700
- Fix typo in controlling-panics-with-std-panic.md (rust-lang/edition-guide#158)
- Fix links for book editions. (rust-lang/edition-guide#149)
- Update now that NLL is enabled in 2015. (rust-lang/edition-guide#157)

## embedded-book

3 commits in de3d55f521e657863df45260ebbca1b10527f662..9858872bd1b7dbba5ec27dc30d34eba00acd7ef9
2019-04-22 12:58:28 +0000 to 2019-05-02 18:56:54 +0000
- Update linux.md  (rust-embedded/book#167)
- Clarify list of available targets for installation  (rust-embedded/book#165)
- minor grammar fix  (rust-embedded/book#188)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants