You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There has been some refactoring/renaming/crate-splitting in the embedded-io traits during the integration into this repository.
It would be good to release a new version including these changes.
Is there anything left to do before its release?
isn't that the point of rc's? if we think the crate is ready for 1.0, we signal that by relasing 1.0-rc1 to request people to try it out and give feedback.
Otherwise we're forcing people to do 2 breaking changes: 0.5 -> 1.0-rc1, and then 1.0-rc1 -> 1.0
I was trying to avoid the situation where there are breaking changes between an rc1 and a potential rc2 release.
However, I have not been involved in embedded-io's history so I would accept your assessment if you are sure it is ready for rc1 and no breaking changes are expected.
okay, let's do 0.5 then. I can't think of any issues, but it's true that ReadReady/WriteReady are new, and also that pointing embedded_hal::Serial users to it will bring more eyes with perhaps new use cases.
I was trying to update Embassy to 0.5, and one thing we've lost since 0.4 is defmt support. I'll send a PR.
Activity
Dirbaio commentedon Aug 6, 2023
I think it should be good to go. Perhaps we can release them as
1.0.0-rc1
?eldruin commentedon Aug 6, 2023
Good question. Since there have been so many changes, how about releasing 0.5 first and after people have migrated then promote it to rc1?
Dirbaio commentedon Aug 6, 2023
isn't that the point of rc's? if we think the crate is ready for 1.0, we signal that by relasing 1.0-rc1 to request people to try it out and give feedback.
Otherwise we're forcing people to do 2 breaking changes: 0.5 -> 1.0-rc1, and then 1.0-rc1 -> 1.0
eldruin commentedon Aug 6, 2023
I was trying to avoid the situation where there are breaking changes between an rc1 and a potential rc2 release.
However, I have not been involved in
embedded-io
's history so I would accept your assessment if you are sure it is ready for rc1 and no breaking changes are expected.Dirbaio commentedon Aug 6, 2023
okay, let's do 0.5 then. I can't think of any issues, but it's true that ReadReady/WriteReady are new, and also that pointing embedded_hal::Serial users to it will bring more eyes with perhaps new use cases.
I was trying to update Embassy to 0.5, and one thing we've lost since 0.4 is
defmt
support. I'll send a PR.Dirbaio commentedon Aug 6, 2023
#481
eldruin commentedon Aug 7, 2023
Thank you @Dirbaio!