Skip to content

Conversation

U007D
Copy link
Contributor

@U007D U007D commented Jan 30, 2019

If one happens to have a standard profile set to unwinding panics, a language item required, but not found: 'eh_personality' will result. This PR adds a brief note explaining how to resolve the error.

@U007D U007D requested a review from a team as a code owner January 30, 2019 16:39
@Disasm Disasm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 26, 2019
@austinglaser
Copy link
Contributor

I'm in favor of adding this language -- I ran into this exact issue when working through the book.

Copy link
Member

@jamesmunns jamesmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

bors r+

bors bot added a commit that referenced this pull request Apr 26, 2020
Merge #42

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
42: added note for 'eh_personality' error r=jamesmunns a=U007D

If one happens to have a standard profile set to unwinding panics, a `language item required, but not found: 'eh_personality'` will result.  This PR adds a brief note explaining how to resolve the error.

Co-authored-by: Brad Gibson <[email protected]>
@bors
Copy link
Contributor

bors bot commented Apr 26, 2020

Build failed:

@jamesmunns
Copy link
Member

Note: will probably need to be rebased on #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants