Fix for extraction of extensions starting with 's'/ 'x'/ 'z'

[AthiraRamakrishna]

When the target has extensions starting from z,s,x the extension extraction fails

[romancardenas]

Hi @AthiraRamakrishna ! Thank you for contributing to riscv tools. Can you attach links or a repo where I can reproduce the issue you mention? I thought these special extensions started with uppercase, but I haven't worked with any of them yet, maybe I'm wrong.

Also, please fix the tests and change the CHANGELOG.md file.

[AthiraRamakrishna]

Hi @romancardenas , I faced this issue when I tried to add features to the riscv-target in the config.toml file through
[build]
target=["riscv32imafc-unknown-none-elf"]
rustflags = [
"-C","link-args=-Tdevice.x",
"-C","target-feature=+zba,+zbb,+zbs,+zcf",
"-C","target-cpu=generic-rv32",
"-C","link-args=-Map=app.map"

]

also when I run the command rustc --target=riscv32imafc-unknown-none-elf -Ctarget-feature=help
I get a list of extensions, all starting with small case.

If I change the extensions to upper case, i get this warning.

[romancardenas]

Then please, update your PR so it passes the CI and I will try to push a new version to crates.io ASAP

[romancardenas]

Also, you need to change this:

riscv/riscv-target-parser/src/extension.rs

Line 166 in d4ea7f4

if value.starts_with("Z") || value.starts_with("S") || value.starts_with("X") {

[AthiraRamakrishna]

Hi @romancardenas , In addition do I update the version in Cargo.toml to v0.1.1? and how about the dependency on the riscv-target-parser in Cargo.toml file of riscv-rt
Or would you do that after review?

[romancardenas]

Yes, please! Update both dependencies.

If I'm not wrong, yanking v0.1.0 and publishing v0.1.1 should lead to the current published riscv-rt using the new version after cargo update. I would like to wait until #254 is merged before a new riscv-rt release.

[romancardenas]

LGTM! Thank you very much

[AthiraRamakrishna]

JFYI, I haven't updated the riscv-rt dependency yet.

[romancardenas]

Oops! Please open a new PR.

[AthiraRamakrishna]

Sorry! I got confused by your comment "If I'm not wrong, yanking v0.1.0 and publishing v0.1.1 should lead to the current published riscv-rt using the new version after cargo update."
Anyway will open a PR

[AthiraRamakrishna]

I dont think I have to update the version in Cargo.toml file of riscv-rt right? because it would anyway take the latest version of riscv-target-parser
[build-dependencies]
riscv-target-parser = { path = "../riscv-target-parser", version = "0.1.0" }

Also if I have to change this to riscv-target-parser = { path = "../riscv-target-parser", version = "0.1.1" }
Do I then change the version of riscv-rt Cargo.toml to 0.15.0? and in turn I have to change the dependency version of riscv-rt to 0.15.0 in "tests-trybuild" and "tests-build"

Please clarify thanks

[romancardenas]

No, this is not necessary. We will have to update dependencies only when a new version of riscv-rt is released

[romancardenas]

Here it is: https://crates.io/crates/riscv-target-parser

[AthiraRamakrishna]

Thank you :)