-
Notifications
You must be signed in to change notification settings - Fork 2.7k
refactor(lint): move lints to separate modules #16364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| ), | ||
| }; | ||
|
|
||
| pub fn output_unknown_lints( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unknown_lints is weird that it analyzes only at package level, and warn if your lint is inherited from workspace. According to the discussion in #16321 (comment), we should probably lint against workspace always plus selected packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the entire analyze_cargo_lints_table should be move into this module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Back to only move output_unknown_lints. We can refactor analyze_cargo_lints_table in next PRs. See #16364 (comment).
851abd8 to
05b1d92
Compare
This comment has been minimized.
This comment has been minimized.
|
r? @Muscraft |
05b1d92 to
4e39141
Compare
|
Windows MSVC https://github.com/rust-lang/cargo/actions/runs/20069081791/job/57565703379 |
What does this PR try to resolve?
Instead of putting everything in a single module,
this moves stuff to their own file for better logic isolation.
How to test and review this PR?