Skip to content

Conversation

@weihanglo
Copy link
Member

What does this PR try to resolve?

Instead of putting everything in a single module,
this moves stuff to their own file for better logic isolation.

How to test and review this PR?

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 8, 2025

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

),
};

pub fn output_unknown_lints(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unknown_lints is weird that it analyzes only at package level, and warn if your lint is inherited from workspace. According to the discussion in #16321 (comment), we should probably lint against workspace always plus selected packages.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the entire analyze_cargo_lints_table should be move into this module.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back to only move output_unknown_lints. We can refactor analyze_cargo_lints_table in next PRs. See #16364 (comment).

@weihanglo weihanglo marked this pull request as draft December 9, 2025 00:34
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 9, 2025
@rustbot

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. label Dec 9, 2025
@epage
Copy link
Contributor

epage commented Dec 9, 2025

r? @Muscraft

@rustbot rustbot assigned Muscraft and unassigned ehuss Dec 9, 2025
@weihanglo
Copy link
Member Author

Windows MSVC

https://github.com/rust-lang/cargo/actions/runs/20069081791/job/57565703379

---- cache_lock::mutate_then_download stdout ----

thread 'cache_lock::mutate_then_download' (10132) panicked at tests\testsuite\cache_lock.rs:15:5:
test did not finish within 10 attempts (1.0022125s total)


failures:
    cache_lock::mutate_then_download

test result: FAILED. 3612 passed; 1 failed; 367 ignored; 0 measured; 0 filtered out; finished in 1087.91s

@weihanglo weihanglo marked this pull request as ready for review December 9, 2025 16:02
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 9, 2025
@weihanglo weihanglo added A-new-lint Area: new lint and removed S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. A-new-lint Area: new lint labels Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants