transmit: send README filename as well as content #4633
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matklad (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
(looks good to me otherwise!) |
|
Yay! lgtm!! @bors: r+ |
|
📌 Commit 76a69b4 has been approved by |
transmit: send README filename as well as content This is required to solve rust-lang/crates.io#995; we currently only send the README content, but not the name of the README itself, so it's not possible to determine how we should render it. I've confirmed the existing crates.io server silently ignores the new field, so this should be safe to roll out whenever.
|
☀️ Test successful - status-appveyor, status-travis |
1134: Record readme filename; use to determine whether to render as Markdown or not r=carols10cents Fixes #995. Depends on rust-lang/cargo#4633 to have the desired effect, but won't break in the absence of that PR; we'll just assume the readme is called `"README.md"` if the client doesn't report one. Small CSS fix included to wrap extra long lines. Comparison of render of https://crates.io/crates/relm's README: | Before | After | | :-: | :-: | |  |  |
7 participants
This is required to solve rust-lang/crates.io#995; we currently only send the README content, but not the name of the README itself, so it's not possible to determine how we should render it.
I've confirmed the existing crates.io server silently ignores the new field, so this should be safe to roll out whenever.