Skip to content

#[aapcs_on_arm] is applied to two functions with no floating point #373

Closed
@AaronKutch

Description

@AaronKutch
Contributor

In PR #332 and in my upcoming PR for fixing issue #367, I have noticed two functions, __multi3 and __divmoddi4, which have #[aapcs_on_arm] for no apparent reason. Amanieu said that all it does is force soft-float convention even on hard-float targets. I checked the arm part of compiler-rt and don't see anything unusual with those functions. Those two functions are the only non-floating-point related functions with #[aapcs_on_arm] on them. Can I remove those two instances of #[aapcs_on_arm] in my two PRs?

Activity

alexcrichton

alexcrichton commented on Aug 18, 2020

@alexcrichton
Member

These are likely a mistake. IIRC we copied this mostly from compiler-rt, but even there it may have been a mistake or we mistakenly copied something over. Should be fine to fix!

AaronKutch

AaronKutch commented on Aug 18, 2020

@AaronKutch
ContributorAuthor

Ok just double checking, I will close this issue once both are fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @alexcrichton@AaronKutch

      Issue actions

        `#[aapcs_on_arm]` is applied to two functions with no floating point · Issue #373 · rust-lang/compiler-builtins