-
Notifications
You must be signed in to change notification settings - Fork 73
Closed
rust-lang/rust
#112858Labels
T-compilerAdd this label so rfcbot knows to poll the compiler teamAdd this label so rfcbot knows to poll the compiler teammajor-changeA proposal to make a major change to rustcA proposal to make a major change to rustcmajor-change-acceptedA major change proposal that was acceptedA major change proposal that was accepted
Description
Proposal
The Android team would like to add support for the riscv64-linux-android
target. We've been building and testing a local version of this patch for several releases and are ready to upstream these changes to support experimental development for the target.
Mentors or Reviewers
chriswailes
Process
The main points of the Major Change Process are as follows:
- File an issue describing the proposal.A compiler team member or contributor who is knowledgeable in the area can second by writing
@rustbot second
.- Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a
-C flag
, then full team check-off is required. - Compiler team members can initiate a check-off via
@rfcbot fcp merge
on either the MCP or the PR.
To pick up a draggable item, press the space bar. While dragging, use the arrow keys to move the item. Press space again to drop the item in its new position, or press escape to cancel.Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.To pick up a draggable item, press the space bar. While dragging, use the arrow keys to move the item. Press space again to drop the item in its new position, or press escape to cancel.
You can read more about Major Change Proposals on forge.
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
Metadata
Metadata
Assignees
Labels
T-compilerAdd this label so rfcbot knows to poll the compiler teamAdd this label so rfcbot knows to poll the compiler teammajor-changeA proposal to make a major change to rustcA proposal to make a major change to rustcmajor-change-acceptedA major change proposal that was acceptedA major change proposal that was accepted
Activity
rustbot commentedon Jun 22, 2023
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
cc @rust-lang/compiler @rust-lang/compiler-contributors
oli-obk commentedon Jun 23, 2023
@rustbot second
Amanieu commentedon Jun 27, 2023
My understanding is that Android will end up requiring a larger set of features than the base GC RISC-V profile. Does this target intend to track the upstream target requirements, in which case this should be considered more of a "beta" target until the exact feature requirements for Android are nailed down?
chriswailes commentedon Jun 28, 2023
You are correct on all accounts. Is "beta" an alternative to "Tier 3"?
the8472 commentedon Jun 28, 2023
Wasi is switching to a
-preview<number>
suffix. See #607riking commentedon Jul 8, 2023
"Target is beta" is something you would describe in the target support document.
wesleywiser commentedon Jul 21, 2023
@rustbot label -final-comment-period +major-change-accepted
Rollup merge of rust-lang#112858 - chriswailes:riscv64-android, r=Mar…
Rollup merge of rust-lang#112858 - chriswailes:riscv64-android, r=Mar…
Rollup merge of rust-lang#112858 - chriswailes:riscv64-android, r=Mar…
Rollup merge of #112858 - chriswailes:riscv64-android, r=Mark-Simulacrum
Rollup merge of #112858 - chriswailes:riscv64-android, r=Mark-Simulacrum