Skip to content

Add support for the riscv64-linux-android target #640

@chriswailes

Description

@chriswailes

Proposal

The Android team would like to add support for the riscv64-linux-android target. We've been building and testing a local version of this patch for several releases and are ready to upstream these changes to support experimental development for the target.

Mentors or Reviewers

chriswailes

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Activity

added
major-changeA proposal to make a major change to rustc
T-compilerAdd this label so rfcbot knows to poll the compiler team
on Jun 22, 2023
rustbot

rustbot commented on Jun 22, 2023

@rustbot
Collaborator

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

oli-obk

oli-obk commented on Jun 23, 2023

@oli-obk
Contributor

@rustbot second

added
final-comment-periodThe FCP has started, most (if not all) team members are in agreement
on Jun 23, 2023
Amanieu

Amanieu commented on Jun 27, 2023

@Amanieu
Member

My understanding is that Android will end up requiring a larger set of features than the base GC RISC-V profile. Does this target intend to track the upstream target requirements, in which case this should be considered more of a "beta" target until the exact feature requirements for Android are nailed down?

chriswailes

chriswailes commented on Jun 28, 2023

@chriswailes
Author

You are correct on all accounts. Is "beta" an alternative to "Tier 3"?

the8472

the8472 commented on Jun 28, 2023

@the8472
Member

Wasi is switching to a -preview<number> suffix. See #607

riking

riking commented on Jul 8, 2023

@riking

"Target is beta" is something you would describe in the target support document.

wesleywiser

wesleywiser commented on Jul 21, 2023

@wesleywiser
Member

@rustbot label -final-comment-period +major-change-accepted

added
to-announceAnnounce this issue on triage meeting
and removed
final-comment-periodThe FCP has started, most (if not all) team members are in agreement
on Jul 21, 2023
added 3 commits that reference this issue on Jul 31, 2023
f478ea5
63ab1fa
d0ae0b3
added a commit that references this issue on Aug 2, 2023
78dadb4
added a commit that references this issue on Oct 17, 2023
c8fe0cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-compilerAdd this label so rfcbot knows to poll the compiler teammajor-changeA proposal to make a major change to rustcmajor-change-acceptedA major change proposal that was accepted

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @Amanieu@oli-obk@chriswailes@riking@wesleywiser

      Issue actions

        Add support for the riscv64-linux-android target · Issue #640 · rust-lang/compiler-team