Integrate crates_io_og_image into the application
#11481
+502
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-enhancement ✨
Turbo87
force-pushed
the
og-image-integration
branch
3 times, most recently
from
bd41b5e to
1b00eba
Compare
This allows us to also use it in the main crate test suite.
Turbo87
force-pushed
the
og-image-integration
branch
from
1b00eba to
c6b4e1c
Compare
Turbo87
force-pushed
the
og-image-integration
branch
from
c6b4e1c to
b09a09e
Compare
Turbo87
commented
Jul 1, 2025
| @@ -306,6 +307,8 @@ impl TestAppBuilder { | |||
| credentials: Credentials::Missing, | |||
| }; | |||
|
|
|||
| let og_image_generator = Arc::new(OgImageGenerator::from_environment().unwrap()); | |||
There was a problem hiding this comment.
This change basically requires everyone to have Typst and oxipng installed to run the tests since all publishing tests are now creating og-images. I'm wondering whether we should make this generator optional and default it to None in the test suite. That would also reduce the overhead of the image creation for most of the tests. 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request integrates the
crates_io_og_imagecrate (introduced in #11436) into the main crates.io application to enable automated OpenGraph image generation for crates. The integration includes adding the OG image generator to the worker environment, implementing background job processing for image generation, and extending storage functionality to handle OG image uploads. Images are automatically generated when crates are published or default versions are updated, with admin commands available for backfilling existing crates.