Skip to content

Search broken for hecs 0.5.1, various iterations of rapier 0.8.0 #1370

Closed
@Ralith

Description

@Ralith

Searches in these crates return no results. Related to #1369?

Activity

Ralith

Ralith commented on Apr 20, 2021

@Ralith
Author

cpal 0.13.3 is also affected.

jyn514

jyn514 commented on Apr 20, 2021

@jyn514
Member

The issue is we uploaded all files with the resource-suffix for a few releases:

$ aws s3 ls s3://rust-docs-rs | grep search-index.*js
2021-03-21 20:50:08        120 search-index-20210321-1.53.0-nightly-f82664191.js
2021-03-22 21:00:32        120 search-index-20210322-1.53.0-nightly-5d04957a4.js
2021-03-23 21:17:49        120 search-index-20210323-1.53.0-nightly-673d0db5e.js
2021-03-24 20:52:42        120 search-index-20210324-1.53.0-nightly-07e0e2ec2.js
2021-04-12 20:52:24        120 search-index-20210412-1.53.0-nightly-d0695c908.js

When I reverted #1324 in #1340, they broke search for all crates built by that toolchain. I don't have permissions to remove those files myself, but @pietroalbini should.

added
A-buildsArea: Building the documentation for a crate
C-bugCategory: This is a bug
on Apr 20, 2021
pietroalbini

pietroalbini commented on Apr 20, 2021

@pietroalbini
Member

Removed those files!

Nemo157

Nemo157 commented on Apr 20, 2021

@Nemo157
Member

hecs search is still broken, it may be that the CDN needs invalidating too.

jyn514

jyn514 commented on Apr 20, 2021

@jyn514
Member

@Nemo157 it's not enough to invalidate the path of the shared files, each individual crate has to be invalidated since we give precedence to global files over local ones.

jyn514

jyn514 commented on Apr 20, 2021

@jyn514
Member

I wonder if it makes sense to add a query string to the global resources with the version of docs.rs they were built by. Then we wouldn't have to keep sending cache invalidations.

jyn514

jyn514 commented on Apr 20, 2021

@jyn514
Member

Oh wait, that requires rustdoc support :/ maybe we could generate a redirect from the page rustdoc links to? Like redirect crates-2021-03-24.js -> crates-2021-03-24.js?docsrs_version=2021-04-01

jyn514

jyn514 commented on Apr 20, 2021

@jyn514
Member

We just did a mass invalidation, this should fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-buildsArea: Building the documentation for a crateC-bugCategory: This is a bug

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @Nemo157@Ralith@pietroalbini@jyn514

        Issue actions

          Search broken for hecs 0.5.1, various iterations of rapier 0.8.0 · Issue #1370 · rust-lang/docs.rs