Closed
Description
Recently docs built on docs.rs use the same purple colour for struct types, enum types, and type definitions.
Compare when building docs locally: only struct types are purple, enum types are green, and type definitions are orange.
Any reason for this change? Types in different colours are helpful when scanning signatures etc. Please revert to different colours for different types if possible.
Activity
syphar commentedon Jan 20, 2022
@glts docs.rs is using nightly to build the docs, so this is probably a recent change to nightly.
cc @GuillaumeGomez ?
glts commentedon Jan 20, 2022
@syphar Thank you. Pity, but I will get used to it.
GuillaumeGomez commentedon Jan 20, 2022
I can't find the PR and issue for this change. Do you have them by any chance @jsha ?
jsha commentedon Jan 20, 2022
It was discussed in this issue and landed in this PR. @glts if you have examples of documentation pages that you find harder to read after this change, I'd be interested to take a look! There are some additional improvements I'd like to make to how slice brackets are colored; I'm curious to see if that would help with your use cases.
Xiphoseer commentedon Jan 23, 2022
Personally, I think it's a significant part of the API whether the main way to interact with a type is using
match val
orval.field
. So to be able to visually distinguish between enums and structs on pages like https://docs.rs/serde_json/latest/serde_json/value/fn.to_value.html for related types likeValue
has been useful to me in the past.GuillaumeGomez commentedon Jan 23, 2022
Please open an issue on the rust repository and tag me and @jsha so we can discuss it.