Skip to content

Is it possible to increase a README character limit? #1866

Closed
@zhiburt

Description

@zhiburt

Crate name

tabled

Build failure link

https://docs.rs/crate/tabled/0.9.0

Requested RAM limit

No response

Requested timeout

No response

Requested number of targets

No response

Why your crate needs the resource increases

Hi there,

Yes....
I guess someone need to redo the README but is it possible to increase the limit?

Take care.

Activity

jyn514

jyn514 commented on Sep 30, 2022

@jyn514
Member

I think we should consider just removing the limit; I don't know why it was added in the first place, but we don't limit the size of the pages rustdoc generates, so I don't know why we'd limit readmes either.

Nemo157

Nemo157 commented on Sep 30, 2022

@Nemo157
Member

There is a limit on rustdoc pages too, it's just (at least by default) a lot more lenient

docs.rs/src/config.rs

Lines 133 to 134 in b5451e0

max_file_size: env("DOCSRS_MAX_FILE_SIZE", 50 * 1024 * 1024)?,
max_file_size_html: env("DOCSRS_MAX_FILE_SIZE_HTML", 50 * 1024 * 1024)?,

I think the problem is the readme is stored in the database instead of being sourced from S3. I remember some discussion on storing the source archive even when the build fails but can't find the issue (related to #1011 though), once we have that then I think we can change to rendering from the source file instead of the database column which will implicitly remove the length restriction.

(We could change to going to S3 when the source archive is available now, though that wouldn't help in this case because the build also failed).

jyn514

jyn514 commented on Sep 30, 2022

@jyn514
Member

(We could change to going to S3 when the source archive is available now, though that wouldn't help in this case because the build also failed).

We upload the source archive even when the build fails, that shouldn't impact anything. I agree that's a good solution and would let us use the same limit for the readme as everything else (and as a bonus make the database a lot smaller).

Nemo157

Nemo157 commented on Sep 30, 2022

@Nemo157
Member

Ah yeah, that explains why I couldn't find the issue, it was already closed #607. We'll still need to read the database as a backup for crates that built before that was fixed until the mass rebuild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @Nemo157@zhiburt@jyn514

      Issue actions

        Is it possible to increase a README character limit? · Issue #1866 · rust-lang/docs.rs