moods for ferris #59
Open
moods for ferris #59
+113
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added a mood implentation to say, namely, added say_with_mood. added one mood: sad Signed-off-by: Ran Regev <[email protected]>
added 3 commits
November 26, 2025 12:29
added a test for say_with_mood with and without the mood parameter clippy tests are diabled as mood is only relevent for non clippy mode. Signed-off-by: Ran Regev <[email protected]>
added mood option to fsay Signed-off-by: Ran Regev <[email protected]>
Signed-off-by: Ran Regev <[email protected]>
Author
|
@lcnr - can you please take a look? |
Author
|
@dtolnay ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #60
added mood implementation
Added implementation to support different moods
tests for mood
Added tests for natural and sad moods
fsay: added mood option
added a command line option to express ferris' mood
added happy mood
added another mood just for joy
This PR is part of me learning rust.
Thanks for having this small library for me to learn from.
If you like it I think documentation is needed as well,
to document my addition - which I wil happily provide