delete ineffective ssh_key_from_memory crate feature#1087
Merged
ehuss merged 1 commit intorust-lang:masterfrom Jan 4, 2025
Merged
delete ineffective ssh_key_from_memory crate feature#1087ehuss merged 1 commit intorust-lang:masterfrom
ehuss merged 1 commit intorust-lang:masterfrom
Conversation
The ssh_key_from_memory crate feature was added in commit 8ca0e92 (2018-07-26). Then it was accidentally made always-on in commit 76f4b74 (2018-09013). Since it seems like no one has missed the ability to turn it off since then (not enough to send a PR anyway), let's just delete the crate feature. Closes rust-lang#363
Contributor
|
Thanks! Will merge with the next major release. |
martinvonz
added a commit
to martinvonz/cargo-generate
that referenced
this pull request
Oct 2, 2024
…om git2-rs The ssh_key_from_memory feature has had no effect in the last 6 years. It will be removed in the next major release (rust-lang/git2-rs#1087) and it will thus be an error to request it.
github-merge-queue bot
pushed a commit
to cargo-generate/cargo-generate
that referenced
this pull request
Oct 3, 2024
…om git2-rs (#1284) The ssh_key_from_memory feature has had no effect in the last 6 years. It will be removed in the next major release (rust-lang/git2-rs#1087) and it will thus be an error to request it. Co-authored-by: Sven Kanoldt <sven@d34dl0ck.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ssh_key_from_memory crate feature was added in commit 8ca0e92 (2018-07-26). Then it was accidentally made always-on in commit 76f4b74 (2018-09013). Since it seems like no one has missed the ability to turn it off since then (not enough to send a PR anyway), let's just delete the crate feature.
Closes #363