Add binding for git_commit_body#835
Merged
joshtriplett merged 1 commit intorust-lang:masterfrom May 1, 2022
Merged
Conversation
This patch adds a binding for git_commit_body to retrieve the commit message without the summary paragraph. Additionally, this patch updates the test suite to test commits with a body paragraph. While the commit body was previously available via Commit::message, users would have to reimplement libgit2's behaviour to extract the commit body from it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a binding for
git_commit_body.While users could previously retrieve the commit body as part of the commit message, they would have to reimplement libgit2's functionality to extract the body paragraphs.
In addition to the new binding, I also updated the test suite to test a commit with a body paragraph instead.
The data users can get with the new binding is useful when displaying the title and body parts of a commit message differently. My use case for this feature is validating the commit body with a separate set of rules in a commit message linter I'm writing.
Thank you for the review in advance!