Skip to content

env: split up Windows and Unix environment variable handling #3517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

RalfJung
Copy link
Member

On Windows, manage them entirely outside the AM state; this also means we no longer report any data races for environment variable memory.

Fixes rust-lang/rust#124411

@RalfJung
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Apr 26, 2024

📌 Commit 96fcee1 has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 26, 2024

⌛ Testing commit 96fcee1 with merge acf44cb...

bors added a commit that referenced this pull request Apr 26, 2024
env: split up Windows and Unix environment variable handling

On Windows, manage them entirely outside the AM state; this also means we no longer report any data races for environment variable memory.

Fixes rust-lang/rust#124411
@bors
Copy link
Contributor

bors commented Apr 26, 2024

💔 Test failed - checks-actions

@RalfJung
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Apr 26, 2024

📌 Commit c53d44b has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 26, 2024

⌛ Testing commit c53d44b with merge 6b787f9...

@bors
Copy link
Contributor

bors commented Apr 26, 2024

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 6b787f9 to master...

@bors bors merged commit 6b787f9 into rust-lang:master Apr 26, 2024
@RalfJung RalfJung deleted the env-vars branch April 27, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_env_get_set_multithreaded fails with Miri on Windows
2 participants