Skip to content

diagnostics: do not repeat the entire message in the span label #4384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2025

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Jun 7, 2025

@RalfJung RalfJung force-pushed the diag-no-repeat branch 2 times, most recently from a4fac5a to de44f04 Compare June 7, 2025 11:36
@oli-obk oli-obk changed the title diagnotics: do not repeat the entire message in the span label diagnostics: do not repeat the entire message in the span label Jun 7, 2025
@RalfJung
Copy link
Member Author

@oli-obk @saethlin what do you think about this change?

@oli-obk oli-obk added this pull request to the merge queue Jun 11, 2025
@oli-obk
Copy link
Contributor

oli-obk commented Jun 11, 2025

yes! avoiding duplication and having more useful information

Merged via the queue into rust-lang:master with commit 8af9aed Jun 11, 2025
8 checks passed
@RalfJung RalfJung deleted the diag-no-repeat branch June 11, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants