-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: add multiple getters mode in generate_getter
#13365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
☔ The latest upstream changes (presumably #13399) made this pull request unmergeable. Please resolve the merge conflicts. |
cbbe4da
to
9859ace
Compare
Hey @Veykril , would love to get a review on this! |
00acca4
to
16d888e
Compare
This commit adds two modes to generate_getter action. First, the plain old working on single fields. Second, working on a selected range of fields.
Thanks for in depth and amazing review, have resolved all of them now! |
Thanks! @bors r+ |
Oh will keep that in mind, thnx for the wisdom 🙇 |
☀️ Test successful - checks-actions |
1 similar comment
☀️ Test successful - checks-actions |
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
This commit adds two modes to generate_getter action.
First, the plain old working on single fields.
Second, working on a selected range of fields.
Should partially solve #13246
If this gets approved will create a separate PR for setters version of the same
Points to help in review:
generate_getter_from_record_info
contains code which is mostly taken from assist before refactorparse_record_fields
find_struct_impl
is changed, before it used to accept a singlefn_name
, now it takes a list of function names to check against. All old impls are updated to create a small list to pass their single element.Assumptions: