[arithmetic_side_effects] Fix #10252

[c410-f3r]

Fix #10252

At least for integers, shifts are already handled by the compiler.

---

changelog: [arithmetic_side_effects]: No longer lints on right or left shifts with constant integers, as the compiler warns about them.
#10309

[rustbot]

r? @giraffate

(rustbot has picked a reviewer for you, use r? to override)

[xFrednet]

Hey @c410-f3r regarding the changelog entry, would you mind telling me what CTFT stands for?

Based on the linked issue, I understand that this change allows shifts, if they're verifiably inside the bounds of the shifted integer. Is that correct?

[c410-f3r]

Hey @c410-f3r regarding the changelog entry, would you mind telling me what CTFT stands for?

CTFE -> Constant Time Function Evaluator

Based on the linked issue, I understand that this change allows shifts, if they're verifiably inside the bounds of the shifted integer. Is that correct?

Yes, Rustc is smart enough to handle out-of-bounds shifts for known integers.

Actually, the term CTFE is being abused and I am not totally sure if this specific part is indeed handled by the CTFE. It is probably best to just say compiler or Rustc instead.

[bors]

☔ The latest upstream changes (presumably #10310) made this pull request unmergeable. Please resolve the merge conflicts.

[xFrednet]

Thank you for the explanation! :)

[c410-f3r]

ping @giraffate

[giraffate]

I'll review this in a few days.

[giraffate]

@bors r+

Thanks!

[bors]

📌 Commit c439373 has been approved by giraffate

It is now in the queue for this repository.

[bors]

⌛ Testing commit c439373 with merge ea4ebed...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing ea4ebed to master...