WIP: add unnecessary_split_off lint

[sebhernandezr]

Thank you for making Clippy better!

We're collecting our changelog from pull request descriptions.
If your PR only includes internal changes, you can just write
changelog: none. Otherwise, please write a short comment
explaining your change.

It's also helpful for us that the lint name is put within backticks (` `),
and then encapsulated by square brackets ([]), for example:

changelog: [`lint_name`]: your change

If your PR fixes an issue, you can add fixes #issue_number into this
PR description. This way the issue will be automatically closed when
your PR is merged.

If you added a new lint, here's a checklist for things that will be
checked during review or continuous integration.

• Followed lint naming conventions
• Added passing UI tests (including committed .stderr file)
• cargo test passes locally
• Executed cargo dev update_lints
• Added lint documentation
• Run cargo dev fmt

Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.

Delete this line and everything above before opening your PR.

---

fixes #4953

Please write a short comment explaining your change (or "none" for internal only changes)

changelog:

[andre-digiexam]

r? @llogiq

[llogiq]

The latter should be enough. Each literal is also a const

[llogiq]

I'd also like to test

let zero = 0;
let vec6 = vec1.split_off(zero);

[llogiq]

So you should look into clippy_utils/src/sym.rs which has a generate! macro call containing all our pre-interned symbols. You can add split_off there and directly use it to compare, which saves the .as_str() overhead. Also please edit the PR description to add a changelog line and squash your commits.

[rustbot]

☔ The latest upstream changes (possibly b379d54) made this pull request unmergeable. Please resolve the merge conflicts.