Skip to content

Rename src/bootstrap/native.rs to llvm.rs #108240

@jyn514

Description

@jyn514
Member

The comment at the top of the file says

//! Compilation of native dependencies like LLVM.
so presumably the logic is that "native" includes C/C++ code that isn't LLVM. But the only C code that's not LLVM is
pub struct TestHelpers {
I think we should move TestHelpers to test.rs and rename native.rs to llvm.rs to make it easier to find for new contributors.

cc @compiler-errors, I think you asked about where to find this code recently.

Activity

added
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.
T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to Rust
E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
E-help-wantedCall for participation: Help is requested to fix this issue.
on Feb 19, 2023
jkvargas

jkvargas commented on Feb 20, 2023

@jkvargas

@rustbot claim

rohaquinlop

rohaquinlop commented on Mar 14, 2023

@rohaquinlop
Contributor

@rustbot claim

jkvargas

jkvargas commented on Mar 27, 2023

@jkvargas

@rustbot claim

added a commit that references this issue on Mar 27, 2023
3917644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustC-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-help-wantedCall for participation: Help is requested to fix this issue.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Participants

    @jkvargas@jyn514@rohaquinlop

    Issue actions

      Rename `src/bootstrap/native.rs` to `llvm.rs` · Issue #108240 · rust-lang/rust