Skip to content

Rename tests/ui/unique to box #109878

Closed
@jyn514

Description

@jyn514
Member

https://github.com/rust-lang/rust/tree/fe0b0428b89802f02a050eab72373b75709d0bce/tests/ui/unique all seem to be testing std::boxed::Box. It hasn't been called unique in many years, and that's now ambiguous with ptr::Unqiue. We should rename the test suite for clarity.

Activity

added
E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.
A-testsuiteArea: The testsuite used to check the correctness of rustc
on Apr 3, 2023
reez12g

reez12g commented on Apr 3, 2023

@reez12g
Contributor

@rustbot claim

Noratrieb

Noratrieb commented on Apr 3, 2023

@Noratrieb
Member

Most of these should be unit tests in library/alloc, not UI tests. Although given the amount of compiler magic behind it it my make sense to keep them as UI tests.

jyn514

jyn514 commented on Apr 3, 2023

@jyn514
MemberAuthor

No objection to that, but renaming the directory doesn't make it any harder to switch them to unit tests in the future.

added
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
on Apr 5, 2023
added a commit that references this issue on Apr 12, 2023

Rollup merge of rust-lang#110000 - reez12g:issue-109878, r=jackh726

90b5597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcC-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @jyn514@reez12g@Noratrieb

    Issue actions

      Rename tests/ui/unique to `box` · Issue #109878 · rust-lang/rust