Skip to content

We are not running std tests for wasm #112009

Open
@jyn514

Description

@jyn514
Member

I tried this code:

x test library --exclude alloc --stage 0

I expected to see this happen: "Testing stage0 library artifacts {std, panic_abort, core, panic_unwind, unwind, proc_macro, test} (x86_64-unknown-linux-gnu)"

Instead, this happened: "Testing stage0 library artifacts"

This gets worse - if I just pass x test --exclude alloc, then the entire step gets skipped. In particular, this means that

# Exclude library/alloc due to OOM in benches.
ENV SCRIPT python3 ../x.py test --stage 2 --host='' --target $TARGETS \
--exclude library/alloc
is excluding all standard library tests, not just the ones for alloc.

Meta

HEAD is branched from 19ee7f4a6abaf00f3d11d1c7f1d3508b55c84aa1 (which is going to land on master shortly).

Activity

added
A-testsuiteArea: The testsuite used to check the correctness of rustc
T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
C-bugCategory: This is a bug.
on May 26, 2023
changed the title [-]Steps that use `crate_or_deps` don't respect `--exclude`[/-] [+]We are not running std tests for wasm[/+] on May 26, 2023
LuuuXXX

LuuuXXX commented on Aug 22, 2023

@LuuuXXX
Contributor

This should be the main cause of the problem.

fn maybe_run(&self, builder: &Builder<'_>, pathsets: Vec<PathSet>) {
if pathsets.iter().any(|set| self.is_excluded(builder, set)) {
return;
}

added a commit that references this issue on Sep 8, 2023

Rollup merge of rust-lang#115088 - LuuuXXX:issue-112009, r=albertlars…

dcb4659
added a commit that references this issue on Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @jyn514@LuuuXXX

        Issue actions

          We are not running std tests for wasm · Issue #112009 · rust-lang/rust