finish and clean up `rustc_const_eval`'s translatable diagnostics.

[fee1-dead]

For some context see this Zulip topic.

cc @RalfJung.

This issue has a few parts:

In #111677 I added a trait called ReportErrorExt which should be replaced by implementing IntoDiagnostic for newtypes. Another thing would be to investigate if the same can be done for MachineStopType which requires being made into a trait object.

this is an example of using fluent's pattern matching for different error messages. These should be eventually replaced by individual messages with their own identifiers instead of pattern matching.

I'll assign this to myself when I get time. Feel free to claim if this is unassigned.

[victor-timofei]

@rustbot claim
I would love to help with this

[fee1-dead]

Hi @victor-timofei, thanks for claiming this! Feel free to open a thread on Zulip and ping me if you get stuck.

[RalfJung]

this is an example of using fluent's pattern matching for different error messages. These should be eventually replaced by individual messages with their own identifiers instead of pattern matching.

That link doesn't seem to work here. What are you referring to?

[fee1-dead]

See this

[CastilloDel]

@rustbot claim

[CastilloDel]

@rustbot release-assignment