Skip to content

Native networking should use SO_REUSEADDR where appropriate #11758

Closed
@alexcrichton

Description

@alexcrichton
Member

Not doing so is causing spurious failures on the bots I believe. This is already done by libuv for us, and I think that libnative should do the same thing in order to keep the two in sync.

Last I looked, I think there's also some business with SO_REUSEPORT for udp sockets. Regardless, I think that we should mirror what libuv is doing for both tcp and udp.

Activity

bnoordhuis

bnoordhuis commented on Jan 24, 2014

@bnoordhuis
Contributor

Apropos UDP, the SO_REUSEADDR flag lets the process steal the port from another process. Libuv does it for (bug-for-bug) backwards compatibility with node.js v0.4 but it's something of a questionable practice. Looking back at it, we should have made it opt-in.

If you're going to be feature compatible with libuv, then this comment may be useful.

alexcrichton

alexcrichton commented on Jan 24, 2014

@alexcrichton
MemberAuthor

Hm, sounds like we shouldn't be doing this. I also appear to have a misconception of what SO_REUSEADDR is, so for now I think we should leave these as-is.

I don't like the spurious failures, but with this in mind we should probably pursue another fix.

added a commit that references this issue on Nov 16, 2023

Auto merge of rust-lang#11758 - y21:clippy_config_references, r=flip1995

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @alexcrichton@bnoordhuis

        Issue actions

          Native networking should use SO_REUSEADDR where appropriate · Issue #11758 · rust-lang/rust