Skip to content

[strict provenance] make compiler's Term and GenericArg conform #119217

Closed
@WaffleLapkin

Description

@WaffleLapkin
Member

Term and GenericArg currently store pointers as NonZeroUsize, which is not ideal:

ptr: NonZeroUsize,

They should really work with NonNull pointers and strict provenance APIs like .map_addr, .mask, etc.

See a PR fixing a similar issue for some context: #110243 (note: in that one I ended up rewriting the whole thing, I think this issue requires far less changes).

Activity

added
E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
on Dec 22, 2023
added
needs-triageThis issue may need triage. Remove it if it has been sufficiently triaged.
on Dec 22, 2023
WaffleLapkin

WaffleLapkin commented on Dec 22, 2023

@WaffleLapkin
MemberAuthor

(I do plan to work on this, but if you want to work on this instead — feel free to @rustbot claim, I can mentor you)
cc @RalfJung

removed
needs-triageThis issue may need triage. Remove it if it has been sufficiently triaged.
on Dec 22, 2023
kamalesh0406

kamalesh0406 commented on Dec 22, 2023

@kamalesh0406
Rajveer100

Rajveer100 commented on Dec 26, 2023

@Rajveer100
Rajveer100

Rajveer100 commented on Dec 26, 2023

@Rajveer100
fee1-dead

fee1-dead commented on Dec 26, 2023

@fee1-dead
Rajveer100

Rajveer100 commented on Dec 26, 2023

@Rajveer100
Noratrieb

Noratrieb commented on Dec 26, 2023

@Noratrieb

20 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-strict-provenanceArea: Strict provenance for raw pointersE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @RalfJung@saethlin@kamalesh0406@WaffleLapkin@Rajveer100

    Issue actions

      [strict provenance] make compiler's `Term` and `GenericArg` conform · Issue #119217 · rust-lang/rust