Skip to content

Rebuilding LLVM after a submodule update is too lazy #122612

Closed
@Zalathar

Description

@Zalathar
Contributor

There's a pattern I've been noticing when building the compiler after a recent LLVM submodule update.

If I do git checkout master && git pull (which happens to include an LLVM submodule update), and then do x build library, the build system will make sure that the LLVM submodule is properly fetched, but it won't actually rebuild LLVM. Instead the build command exits successfully, presumably using the old LLVM artifacts.

Then if I do x build library a second time, the build system notices that LLVM is stale, and actually rebuilds it.

@rustbot label +T-bootstrap

Activity

added
needs-triageThis issue may need triage. Remove it if it has been sufficiently triaged.
T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
on Mar 17, 2024
removed
needs-triageThis issue may need triage. Remove it if it has been sufficiently triaged.
on Mar 17, 2024
self-assigned this
on Mar 17, 2024
added 2 commits that reference this issue on Apr 16, 2024

Rollup merge of rust-lang#122632 - onur-ozkan:fix-llvm-caching-bug, r…

04a2e3c

Rollup merge of rust-lang#122632 - onur-ozkan:fix-llvm-caching-bug, r…

592b1ca
added a commit that references this issue on Apr 16, 2024
b19896a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

C-bugCategory: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @Zalathar@onur-ozkan@rustbot

    Issue actions

      Rebuilding LLVM after a submodule update is too lazy · Issue #122612 · rust-lang/rust