Skip to content

Buggy debuginfo test suite, or just function-names.rs? #126060

Open
@workingjubilee

Description

@workingjubilee
Member

In #125958 (a PR which changes the way consts are handled in the compiler, and thus alters details like their hashing, etc.) a few lines were trimmed out of a debuginfo test because it was unreasonable to get it to work, despite the function names seemingly being present.

It seems like there might be a bug in the way that the debuginfo test suite handles [...]? Or it might incorrectly treat certain checks as ordering-sensitive, when hashing can change orders? It's unclear, but in any case, undesirable.

This mostly affected the Windows variant of the test.

Activity

added
O-windowsOperating system: Windows
A-debuginfoArea: Debugging information in compiled programs (DWARF, PDB, etc.)
C-bugCategory: This is a bug.
on Jun 6, 2024
added
needs-triageThis issue may need triage. Remove it if it has been sufficiently triaged.
on Jun 6, 2024
workingjubilee

workingjubilee commented on Jun 6, 2024

@workingjubilee
MemberAuthor
michaelwoerister

michaelwoerister commented on Jun 6, 2024

@michaelwoerister
Member

Thanks for the pointer, @workingjubilee! I'll take a look.

added
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
and removed
needs-triageThis issue may need triage. Remove it if it has been sufficiently triaged.
on Jun 7, 2024
workingjubilee

workingjubilee commented on Jun 10, 2024

@workingjubilee
MemberAuthor

To concretize this issue slightly further, I'd like to apply changes as close as possible to the other ones in this patch to the debuginfo test suite: #125963

BoxyUwU

BoxyUwU commented on Jul 2, 2024

@BoxyUwU
Member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-debuginfoArea: Debugging information in compiled programs (DWARF, PDB, etc.)C-bugCategory: This is a bug.O-windowsOperating system: WindowsT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @michaelwoerister@saethlin@BoxyUwU@workingjubilee@rustbot

        Issue actions

          Buggy debuginfo test suite, or just `function-names.rs`? · Issue #126060 · rust-lang/rust