Skip to content

[discussion] ErrorKind::CrossesDevices from io_error_more #130191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
GrigorenkoPV opened this issue Sep 10, 2024 · 7 comments
Closed

[discussion] ErrorKind::CrossesDevices from io_error_more #130191

GrigorenkoPV opened this issue Sep 10, 2024 · 7 comments
Labels
C-discussion Category: Discussion or questions that doesn't represent real issues. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Milestone
1.85.0

Comments

@GrigorenkoPV
Copy link
Contributor

GrigorenkoPV commented Sep 10, 2024 •
edited
Loading

@rustbot label C-discussion

Main tracking issue: #86442

Background

The io_error_more feature introduced 21 new variants into ErrorKind. They were FCP'd back in December 2022, but there appeared to be quite a lot of disagreement about 4 of the added variants, so the stabilization (#106375) got stalled for over twenty months. Thankfully, the 17 uncontroversial variants got stabilized in #128316, so now we just need to iron out a satisfactory design for the remaining 4 variants, and then they can be stabilized too.

In order to not block any of the remaining variants on each other and to not intertwine the discussions, I've created 4 separate issues, which summarize the concerns & suggestions voiced up until this point and can serve as a place for further discussion.

CrossesDevices

Currently corresponds to EXDEV on Unix and ERROR_NOT_SAME_DEVICE on Windows. (#86442 (comment))

Current docs description:

Cross-device or cross-filesystem (hard) link or rename.

NotSameDevice

I think NotSameDevice is a better name than CrossesDevices. For me, it expresses its meaning more clearly. FWIW, the Linux man page also uses the word "same" to describe EXDEV: oldpath and newpath are not on the same mounted filesystem.

Also, I find NotSameDevice to be stylistically more consistent with the other existing and proposed error identifiers.

Originally posted by kalcutter in #86442 (comment)

Would you also consider NotSameDevice instead of CrossesDevices?

Originally posted by kalcutter in #106375 (comment)

I personally don't think we should rename CrossesDevices.

Originally posted by Josh Triplett in #106375 (comment)
@rustbot rustbot added needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. C-discussion Category: Discussion or questions that doesn't represent real issues. labels Sep 10, 2024
This was referenced Sep 10, 2024
Open
Merged
@dtolnay dtolnay added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Sep 10, 2024
@dtolnay
Copy link
Member

dtolnay commented Sep 10, 2024

@rfcbot fcp merge

I propose stabilizing CrossesDevices if there are 2 other team members on board. As of #106375 (comment), Josh prefers this name.

Alternatively, if 2 other team members prefer a rename to NotSameDevice, I propose stabilizing NotSameDevice.

@rfcbot
Copy link
Collaborator

rfcbot commented Sep 10, 2024 •
edited by Amanieu
Loading

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Sep 10, 2024
This was referenced Sep 10, 2024
Open
Closed
Merged
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 10, 2024
@joshtriplett
Copy link
Member

Checked my box for CrossesDevices.

@joshtriplett
Copy link
Member

Ping @Amanieu @BurntSushi @m-ou-se

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Nov 26, 2024
@rfcbot
Copy link
Collaborator

rfcbot commented Nov 26, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Dec 6, 2024
@rfcbot
Copy link
Collaborator

rfcbot commented Dec 6, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@rustbot rustbot mentioned this issue Dec 6, 2024
Closed
3 tasks
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 6, 2024
@matthiaskrgr
Rollup merge of rust-lang#130209 - GrigorenkoPV:CrossesDevices, r=dto…
14710ec 
…lnay

Stabilize `std::io::ErrorKind::CrossesDevices`

FCP in rust-lang#130191

cc rust-lang#86442

See rust-lang#130191 for more info and a recap of what has happened up until now.

TLDR: This had been FCP'd in December 2022 with some other `ErrorKind`s, but the stabilization got postponed due to some concerns voiced about several of the variants. However, the only concern ever voiced for this variant in particular was a wish to rename this to `NotSameDevice` analogous to Windows's `ERROR_NOT_SAME_DEVICE` (as opposed to Unix's `EXDEV`). This suggestion did not receive any support. So let's try to FCP this as is.

r? libs-api
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Dec 7, 2024
@rust-timer
Unrolled build for rust-lang#130209
66313cb 
Rollup merge of rust-lang#130209 - GrigorenkoPV:CrossesDevices, r=dtolnay

Stabilize `std::io::ErrorKind::CrossesDevices`

FCP in rust-lang#130191

cc rust-lang#86442

See rust-lang#130191 for more info and a recap of what has happened up until now.

TLDR: This had been FCP'd in December 2022 with some other `ErrorKind`s, but the stabilization got postponed due to some concerns voiced about several of the variants. However, the only concern ever voiced for this variant in particular was a wish to rename this to `NotSameDevice` analogous to Windows's `ERROR_NOT_SAME_DEVICE` (as opposed to Unix's `EXDEV`). This suggestion did not receive any support. So let's try to FCP this as is.

r? libs-api
@GrigorenkoPV
Copy link
Contributor Author

Stabilized in #130209, closing.

@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Dec 19, 2024
@Mark-Simulacrum Mark-Simulacrum added this to the 1.85.0 milestone Jan 20, 2025
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this issue Mar 11, 2025
@matthiaskrgr
Rollup merge of rust-lang#130209 - GrigorenkoPV:CrossesDevices, r=dto…
442df57 
…lnay

Stabilize `std::io::ErrorKind::CrossesDevices`

FCP in rust-lang#130191

cc rust-lang#86442

See rust-lang#130191 for more info and a recap of what has happened up until now.

TLDR: This had been FCP'd in December 2022 with some other `ErrorKind`s, but the stabilization got postponed due to some concerns voiced about several of the variants. However, the only concern ever voiced for this variant in particular was a wish to rename this to `NotSameDevice` analogous to Windows's `ERROR_NOT_SAME_DEVICE` (as opposed to Unix's `EXDEV`). This suggestion did not receive any support. So let's try to FCP this as is.

r? libs-api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-discussion Category: Discussion or questions that doesn't represent real issues. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

No branches or pull requests
8 participants
@joshtriplett @dtolnay @Mark-Simulacrum @apiraino @rfcbot @jieyouxu @rustbot @GrigorenkoPV