Skip to content

rust-url's debugger_visualizer tests are broken in rustc nightly-2024-08-13 #130431

Closed
@valenting

Description

@valenting

I was looking into servo/rust-url#967 but I wasn't able to reproduce the failures locally. Then I realized I was running an older nightly.

I used bisect-rustc and got the following output:


searched nightlies: from nightly-2024-08-01 to nightly-2024-09-16
regressed nightly: nightly-2024-08-13
searched commit range: 41dd149...91376f4
regressed commit: 13f8a57

bisected with cargo-bisect-rustc v0.6.9

Host triple: x86_64-pc-windows-msvc
Reproduce with:

cargo bisect-rustc --start=2024-08-01 --end=2024-09-16 --test-dir=rust-url -- test --test debugger_visualizer --features url/debugger_visualizer,url_debug_tests/debugger_visualizer -- --test-threads=1 --nocapture

The PR that introduced the issue seems to be: #126793

Example failing job: https://github.com/servo/rust-url/actions/runs/10879435038/job/30184131451

Activity

added
I-prioritizeIssue: Indicates that prioritization has been requested for this issue.
needs-triageThis issue may need triage. Remove it if it has been sufficiently triaged.
on Sep 16, 2024
jieyouxu

jieyouxu commented on Sep 16, 2024

@jieyouxu
Member

cc @saethlin since you authored #126793 and are more familiar with debuggers

added
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
on Sep 16, 2024
added
E-needs-mcveCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example
C-discussionCategory: Discussion or questions that doesn't represent real issues.
and removed
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
C-bugCategory: This is a bug.
E-needs-mcveCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example
I-prioritizeIssue: Indicates that prioritization has been requested for this issue.
regression-untriagedUntriaged performance or correctness regression.
needs-triageThis issue may need triage. Remove it if it has been sufficiently triaged.
on Sep 16, 2024

5 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-discussionCategory: Discussion or questions that doesn't represent real issues.WG-debuggingWorking group: Bad Rust debugging experiences

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @valenting@saethlin@jieyouxu@rustbot

        Issue actions

          rust-url's debugger_visualizer tests are broken in rustc nightly-2024-08-13 · Issue #130431 · rust-lang/rust