Skip to content

Tracking issue for release notes of #128400: linker: Remove the "--whole-archive in test mode" backcompat hack #130790

Closed
@rustbot

Description

@rustbot
Collaborator

This issue tracks the release notes text for #128400.

Steps

  • Proposed text is drafted by PR author (or team) making the noteworthy change.
    Issue is nominated for release team review of clarity for wider audience.
    Release team includes text in release notes/blog posts.

Release notes text

The responsible team for the underlying change should edit this section to replace the automatically generated link with a succinct description of what changed, drawing upon text proposed by the author (either in discussion or through direct editing).

# Compatibility Notes
- [Removes a problematic hack that always passed the --whole-archive linker flag for tests, which may cause linker errors for code accidentally relying on it.](https://github.com/rust-lang/rust/pull/128400)

Tip

Use the previous releases categories to help choose which one(s) to use.
The category will be de-duplicated with all the other ones by the release team.

More than one section can be included if needed.

Release blog section

If the change is notable enough for inclusion in the blog post, the responsible team should add content to this section.
Otherwise leave it empty.

cc @petrochenkov, @bjorn3 -- origin issue/PR authors and assignees for starting to draft text

Activity

added
relnotesMarks issues that should be documented in the release notes of the next release.
relnotes-tracking-issueMarks issues tracking what text to put in release notes.
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
on Sep 24, 2024
added this to the 1.82.0 milestone on Sep 24, 2024
added
needs-triageThis issue may need triage. Remove it if it has been sufficiently triaged.
on Sep 24, 2024
added
A-linkageArea: linking into static, shared libraries and binaries
and removed
needs-triageThis issue may need triage. Remove it if it has been sufficiently triaged.
on Sep 24, 2024
Noratrieb

Noratrieb commented on Sep 25, 2024

@Noratrieb
Member

Compatibility: Removes a problematic hack that always passed the --whole-archive linker flag for tests, which may cause linker errors for code accidentally relying on it.

maybe a bit long?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-linkageArea: linking into static, shared libraries and binariesT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.relnotesMarks issues that should be documented in the release notes of the next release.relnotes-tracking-issueMarks issues tracking what text to put in release notes.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @cuviper@saethlin@rustbot@Noratrieb

        Issue actions

          Tracking issue for release notes of #128400: linker: Remove the "`--whole-archive` in test mode" backcompat hack · Issue #130790 · rust-lang/rust