Skip to content

make install is broken #13128

Closed
Closed
@alsam

Description

@alsam

Hello,

Looks like make install is broken:

make install
cfg: build triple x86_64-unknown-linux-gnu
cfg: host triples x86_64-unknown-linux-gnu
cfg: target triples x86_64-unknown-linux-gnu
cfg: enabling more debugging (CFG_ENABLE_DEBUG)
cfg: host for x86_64-unknown-linux-gnu is x86_64
cfg: os for x86_64-unknown-linux-gnu is unknown-linux-gnu
cfg: using gcc
cfg: no llnextgen found, omitting grammar-verification
cfg: including prepare rules
cfg: including install rules
make: *** No rule to make target `prepare-everything', needed by `install'.  Stop.
find . -name '*'|xargs egrep 'prepare\-everything'
./mk/install.mk:install: prepare-everything
...

digging a bit:

commit d62163188a21e5afc3d0f476eaf7856d91f715b2
Author: Brian Anderson <banderson@mozilla.com>
Date:   Mon Mar 24 12:04:27 2014 -0700

    Revert "mk: Run 'make install' through install.sh"

    This reverts commit e93709a911637194835268420e67d768ee19b5df.

and

git diff c796f89dbc3e61845d1e44d117acc471f583c417 d62163188a21e5afc3d0f476eaf7856d91f715b2 |less
...
+install: PREPARE_HOST=$(CFG_BUILD)
+install: PREPARE_TARGETS=$(CFG_TARGET)
+install: PREPARE_DIR_CMD=$(DEFAULT_PREPARE_DIR_CMD)
+install: PREPARE_BIN_CMD=$(DEFAULT_PREPARE_BIN_CMD)
+install: PREPARE_LIB_CMD=$(DEFAULT_PREPARE_LIB_CMD)
+install: PREPARE_MAN_CMD=$(DEFAULT_PREPARE_MAN_CMD)
+install: PREPARE_SOURCE_DIR=$(PREPARE_HOST)/stage$(PREPARE_STAGE)
+install: PREPARE_SOURCE_BIN_DIR=$(PREPARE_SOURCE_DIR)/bin
+install: PREPARE_SOURCE_LIB_DIR=$(PREPARE_SOURCE_DIR)/$(CFG_LIBDIR_RELATIVE)
+install: PREPARE_SOURCE_MAN_DIR=$(S)/man
+install: PREPARE_DEST_BIN_DIR=$(DESTDIR)$(CFG_PREFIX)/bin
+install: PREPARE_DEST_LIB_DIR=$(DESTDIR)$(CFG_LIBDIR)
+install: PREPARE_DEST_MAN_DIR=$(DESTDIR)$(CFG_MANDIR)/man1
+install: prepare-everything
...

Thanks

Activity

huonw

huonw commented on Mar 25, 2014

@huonw
Member
brson

brson commented on Mar 25, 2014

@brson
Contributor

Working on it.

self-assigned this
on Mar 25, 2014
added a commit that references this issue on Mar 25, 2014
1f35f83
alsam

alsam commented on Mar 26, 2014

@alsam
Author

Thanks!
Indeed make install has passed smoothly.

alsam

alsam commented on Mar 28, 2014

@alsam
Author

Unfortunately make install is broken again:

sudo make install
...

prepare: tmp/dist/rust-0.10-pre-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/librustdoc-*.so
prepare: tmp/dist/rust-0.10-pre-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libfourcc-*.so
prepare: tmp/dist/rust-0.10-pre-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libhexfloat-*.so
prepare: tmp/dist/rust-0.10-pre-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libmorestack.a
prepare: tmp/dist/rust-0.10-pre-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler-rt.a
/mnt/disk2/opt/pkgs/rust/mk/install.mk:13: *** unterminated variable reference.  Stop.
sudo make -n install
...
install -m644 /mnt/disk2/opt/pkgs/rust/LICENSE-MIT tmp/dist/rust-0.10-pre-x86_64-unknown-linux-gnu
install -m644 /mnt/disk2/opt/pkgs/rust/README.md tmp/dist/rust-0.10-pre-x86_64-unknown-linux-gnu
install -m755 /mnt/disk2/opt/pkgs/rust/src/etc/install.sh tmp/dist/rust-0.10-pre-x86_64-unknown-linux-gnu
/mnt/disk2/opt/pkgs/rust/mk/install.mk:13: *** unterminated variable reference.  Stop.
sh -x /mnt/disk2/opt/pkgs/rust/src/etc/install.sh tmp/dist/rust-0.10-pre-x86_64-unknown-linux-gnu
...
+ test 0 -eq 0
+ err Option 'tmp/dist/rust-0.10-pre-x86_64-unknown-linux-gnu' is not recognized
+ echo install: error: Option 'tmp/dist/rust-0.10-pre-x86_64-unknown-linux-gnu' is not recognized
install: error: Option 'tmp/dist/rust-0.10-pre-x86_64-unknown-linux-gnu' is not recognized
+ exit 1

Does it make sense to file a new bug or just reopen this one?

Thanks!

alexcrichton

alexcrichton commented on Mar 28, 2014

@alexcrichton
Member

What version of the compiler did you get that error on? I think it was fixed very recently in 476f0e3, but I could be wrong!

alsam

alsam commented on Mar 28, 2014

@alsam
Author

Hello Alex,
This is

gcc --version
gcc (Ubuntu/Linaro 4.8.1-10ubuntu9) 4.8.1
Copyright (C) 2013 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
uname -a
Linux chisel 3.11.0-18-generic #32-Ubuntu SMP Tue Feb 18 21:11:14 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux

This is Kubuntu 13.10
Thanks!

huonw

huonw commented on Mar 28, 2014

@huonw
Member

@alsam I think @alexcrichton was wondering which version of rust you were building, i.e. if it included the revision 476f0e3.

alsam

alsam commented on Mar 28, 2014

@alsam
Author

You are quite right, it was really fixed with 476f0e3

...
install: /usr/local/bin/rustdoc
install: /usr/local/bin/rustc

    Rust is ready to roll.

Sorry for the false alarm.

huonw

huonw commented on Mar 28, 2014

@huonw
Member

Thanks for monitoring it closely. :)

added a commit that references this issue on Oct 26, 2022

Auto merge of rust-lang#13128 - Veykril:invocation-strategy, r=Veykril

1 remaining item

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @alexcrichton@brson@emberian@huonw@alsam

      Issue actions

        `make install` is broken · Issue #13128 · rust-lang/rust