-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Rustdoc search ranking regression in 1.82 #133017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Likely #129430, cc @lolbinarycat @notriddle |
Marking P-critical, but feel free to downgrade to P-high. |
I think the high-level solution would be to cease factoring in case-sensitivity when ranking search results if the search string doesn't contain any uppercase letters. Reworded, only if the input string contains some uppercase letters consider case-sensitivity when ranking. I believe I've seen that behavior in other applications. For example, for write the ranking should match the one "of <1.82" but for Write the ranking can match the one "of ≥1.82". |
I agree with that solution. Vim's search behaves this way under the name |
Rollup merge of rust-lang#133043 - notriddle:master, r=fmease rustdoc-search: case-sensitive only when capitals are used This is the "smartcase" behavior, described by vim and dtolnay. Fixes rust-lang#133017
Uh oh!
There was an error while loading. Please reload this page.
Compare these two rankings:
In 1.81,
std::io::Write
shows up as number 5, after three functions calledwrite
in std::{fmt, fs, ptr} and after std::fmt::Write. These results look decent enough to me.In 1.82,
std::io::Write
is at number 36, after things like<std::io::Stdout as std::io::Write>::write
. I don't think there is any justification for<std::io::Stdout as std::io::Write>::write
andstd::io::Write::write
to outrankstd::io::Write
when searching for "write".The most recent nightly continues to be affected (https://doc.rust-lang.org/nightly/std/?search=write).
The text was updated successfully, but these errors were encountered: