Open
Description
I'm not sure why this passes in CI though.
Surely we have some jobs that enable LLVM assertions?Seems like not, test jobs typically don't enable LLVM assertions due to slowness.That doesn't sound right. LLVM assertions are supposed to be enabled for all test jobs, except those marked NO_LLVM_ASSERTIONS, which is only the apple ones.
Metadata
Metadata
Assignees
Labels
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.Area: The compiletest test runnerArea: Debugging information in compiled programs (DWARF, PDB, etc.)Area: The `rust.download-rustc` build option.Area: test infrastructure (may span bootstrap/compiletest/more)Category: This is a bug.Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the infrastructure team, which will review and decide on the PR/issue.
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Activity
[-]Investigate LLVM assertions being absent when `download-rustc` is enabled in test jobs[/-][+]Investigate LLVM assertions being absent when `download-rustc` is eligible and enabled in test jobs[/+]jieyouxu commentedon Mar 11, 2025
See also #138254 (comment):
jieyouxu commentedon Mar 11, 2025
Thread: #t-compiler > tests/run-make/repr128-dwarf @ 💬
[-]Investigate LLVM assertions being absent when `download-rustc` is eligible and enabled in test jobs[/-][+]Investigate LLVM assertions being possibly absent when `download-rustc` is eligible and enabled in test jobs[/+][-]Investigate LLVM assertions being possibly absent when `download-rustc` is eligible and enabled in test jobs[/-][+]Investigate why repr-128-dwarf doesn't fail in CI test jobs[/+]ehuss commentedon Mar 12, 2025
I think I understand what happened.
debuginfo-level-std
set.debuginfo-level-std
set.repr128
enums #137643 were modifying things like the compiler or bootstrap, and so were not downloading rustc.debuginfo-level-std
set.I'm not sure what the best resolution would be. Some ideas:
download-rustc
logic only downloads a rustc that has the exact same configuration as the current build.jieyouxu commentedon Mar 12, 2025
I think it may be worth trying to enable it on at least some test builders, subject to the usual CI build time efforts.
jieyouxu commentedon Mar 13, 2025
And for compiletest side, I think that test probably needs to be gated by sth like